search

azavea / python-omgeo

OMGeocoder - A python geocoding abstraction layer
http://python-omgeo.readthedocs.io/en/latest/
MIT License
36 stars 14 forks source link

Move flake8 installation from setup.py to .travis.yml #57

Closed KlaasH closed 6 years ago

KlaasH commented 6 years ago

Flake8 shouldn't be required for production installation, but putting it in setup_requires causes it to be installed (or to crash while trying to install, in some cases). Just installing it and running it within the Travis config avoids any problems around around how to specify it in setup.py.

I hadn't seen issue #55, I just started poking at this in hopes that it would be a quick fix since it's blocking the Cicero build. This seems like a good answer to me--making linting happen entirely in CI, rather than introducing any kind of package dependency for it.

Replaces PR #56 Resolves #55

maurizi commented 6 years ago

BTW when you create the 6.0.1 release, make sure to update the changelog and bump the version number