search

azavea / python-sld

A simple python library that enables dynamic SLD creation and manipulation.
http://azavea.github.com/python-sld/
Apache License 2.0
27 stars 17 forks source link

Min- & MaxScaleDominator #6

Closed ewsterrenburg closed 10 years ago

ewsterrenburg commented 12 years ago

I added support for Min- & MaxScaleDominators. If you like it, you could add it to your version.

Ps: this is my first github pull request. If I did some stuff wrong, please don't blame me but give me tips ;)

dzwarg commented 11 years ago

@ewsterrenburg:

Thanks for the addition! I can merge this into master if you add some tests for these attributes.

Check out the existing test suite for examples of all the other tests in the package.

prologic commented 10 years ago

@ewsterrenburg: Could you gets these tests done so this PR can be merged? :)

ewsterrenburg commented 10 years ago

Ups, completely forgot about this. Thanks for the reminder. I'll look into it next week.

Kind regards Erwin Op 16 jun. 2014 05:01 schreef "James Mills" notifications@github.com:

@ewsterrenburg https://github.com/ewsterrenburg: Could you gets these tests done so this PR can be merged? :)

— Reply to this email directly or view it on GitHub https://github.com/azavea/python-sld/pull/6#issuecomment-46137528.

ewsterrenburg commented 10 years ago

(finally) wrote the tests for this :)

prologic commented 10 years ago

Good work :)

James Mills / prologic

E: prologic@shortcircuit.net.au W: prologic.shortcircuit.net.au

On Thu, Jul 31, 2014 at 6:57 PM, ewsterrenburg notifications@github.com wrote:

(finally) wrote the tests for this :)

— Reply to this email directly or view it on GitHub https://github.com/azavea/python-sld/pull/6#issuecomment-50734239.

ewsterrenburg commented 10 years ago

One sec, made a typo during last cleanup. Now running all tests for a final time.

ewsterrenburg commented 10 years ago

Ran 38 tests in 627.048s

OK

dzwarg commented 10 years ago

Thank you, @ewsterrenburg! Looks good. I just delinted and bumped up the version. The new version is on pypi.python.org, and docs will be on pythonhosted.org later.