Closed rajadain closed 8 years ago
It looks like this may actually be valid .dockerignore
syntax. Adding this to the directory that contains the Dockerfile
should reduce the amount of local data sent to the Docker daemon for the build context:
*
!geop/target/scala-2.10/*.jar
That's a great find, I added it.
On Friday I tried moving the Dockerfile to a folder with nothing else, but found that too confusing and not in keeping with our convention of keeping the Dockerfile in the root. This is much nicer.
I think the most recent commits should capture everything.
I looked into using program-analysis
instead of programanalysis
as the package name in Scala, so we can have consistency between the repo name usace-program-analysis-geoprocessing
and the JAR file usace-programanalysis-geop
but having hyphens there is generally frowned upon. Between having the JAR file match the repo name (run / build time) and the class name (design time), I preferred it matching the class name, since now with Docker the actual JAR file is pretty much abstracted away for run time, and build time values are probably not going to be touched very much after this.
👍 Nicely done.
Thanks for pairing with me on this and teaching me about Docker and Quay!
Overview
Instead of building a JAR which gets included in a Docker image by the client repository, we publish a Docker image on Quay which can immediately be included by the client.
This branch is a cleaned up version of work done in feature/hmc/docker.
Testing Instructions
Test Docker by running
Not sure what the best way is to test Travis, but one way is to see success in the final build of the source branch, and the diff between this work and the source branch:
Connects https://github.com/azavea/usace-program-analysis/issues/5