search

azayneeva / week-5-YARA

Marvel Hero Hunter
https://pacific-hollows-10453.herokuapp.com/
0 stars 0 forks source link

whaaaa...? #35

Open morkeltry opened 7 years ago

morkeltry commented 7 years ago

[nodemon] app crashed - waiting for file changes before starting...

This seems to happen after waiting a while - not sure how to reproduce this, sorry!

`the waterfall else case has called a waterfall round has started makeCharacterUrl has run url: https://gateway.marvel.com/v1/public/characters?name=nick%20cage&apikey=7759bf69dd03ab99ee7d615925b09299&ts=1501233305638&hash=671c935b03c526f88cf2bcad1857a4a8 a waterfall round has ended api call has started characterProfile has started /home/treagh/project-wks5-6/YARA/week-5-YARA/src/logic.js:89 if (results.length === 0) { ^

TypeError: Cannot read property 'length' of undefined at characterProfile (/home/treagh/project-wks5-6/YARA/week-5-YARA/src/logic.js:89:16) `

finnhodgkin commented 7 years ago

This issue title isn't appropriate.

Code review is as much about reviewing other people's code as it is about learning how to leave constructive feedback. The issue body is fine (though ideally there'd be a bit more information about the steps you took before the error) but the title just isn't useful at all.