search

azazdeaz / react-gsap-enhancer

Use the full power of React and GSAP together
MIT License
727 stars 38 forks source link

Is there a reason `gsap` and `react` are not declared in peerDependencies? #30

Open antitoxic opened 8 years ago

antitoxic commented 8 years ago

They are required and also mentioned in the readme.

azazdeaz commented 8 years ago

Hey, GSAP is not declared because it's commonly used as a script tag import. I left React out as well because i don't have a sable understanding about how peerDependencies works and i can't imagine that anyone would use this without React.

Do you think we should add something like 

"peerDependencies": {
  "react": "^0.14.0 || ^15.0.0-0",
}

to the package.json?

antitoxic commented 8 years ago

Peer dependencies are just like warnings to the developer for packages that are addons to other.

About the example - yes I think it will be sufficient. However I think gsap should also be included. If I install react-gsap-enhancer via npm/yarn/jspm then it's 99% certain that I'm also including gsap the same way.

If someone is using react-gsap-enhancer via a script tag, then the whole package.json doesn't matter :)

sebastiancarlsson commented 7 years ago

I'm installing react-gsap-enhancer through npm but including GSAP from a CDN (as a script tag)