azbycxdw909 / garglk

Automatically exported from code.google.com/p/garglk
Other
0 stars 0 forks source link

Incorrect Free Software Foundation address in GPL notice in various terp source files #153

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm trying to get Gargoyle added as a Fedora package -

https://bugzilla.redhat.com/show_bug.cgi?id=682544

- and one of the issues the reviewer (via the "rpmlint" tool) highlighted is 
that several of the source files have an outdated FSF address in their GPL 
notice. I'm attaching the rpmlint output which has the list of all affected 
files.

The incorrect address that some files have:

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111, USA.

As per http://www.gnu.org/licenses/gpl-2.0.txt, this should be:

    You should have received a copy of the GNU General Public License
    along with this program; if not, write to the Free Software
    Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

This affects none of the gargoyle-specific code, only some interpreters, namely 
agility, frotz, jacl, level9, magnetic, nitfol, scare.

I wasn't sure if I should report this to the owners of the respective terps 
too; as Gargoyle does not use the most recent source code in all cases though, 
it possibly needs to be fixed separately in Gargoyle.

I don't think this is a blocker for getting this into Fedora, but apparently it 
should be addressed.

I'd be happy to prepare a patch against gargoyle SVN, if that's the way you 
want to go.

Original issue reported on code.google.com by carlo.te...@gmail.com on 2 Jul 2011 at 12:33

Attachments:

GoogleCodeExporter commented 8 years ago
Hi Carlo,

If you could put together a patch, I would appreciate it.

There is a new version of the Level 9 interpreter that I need to review and 
merge in. There's also an updated version of Nitfol but it switched from C to a 
.NET language. Our Frotz is a fork of the original; it's possible the licensing 
issue was addressed upstream.

JACL is actively maintained but the remaining ones are not, to the best of my 
knowledge.

Thanks,
Ben

Original comment by bcressey@gmail.com on 2 Jul 2011 at 1:50

GoogleCodeExporter commented 8 years ago
Attached patch.

Original comment by carlo.te...@gmail.com on 2 Jul 2011 at 5:29

Attachments:

GoogleCodeExporter commented 8 years ago
Ah sorry, that patch is against version 2010.1. I will also prepare a patch 
against the latest SVN version.

Original comment by carlo.te...@gmail.com on 2 Jul 2011 at 5:30

GoogleCodeExporter commented 8 years ago
New patch (attached) is against current SVN trunk. This should be a pretty 
comprehensive replacement of old FSF addresses by the current one, in all 
files, including not only terps but also SDL code. Also in the TADS license 
files, and in "licenses/GNU General Public License.txt", which is a bit naughty 
since that file explicitly says:

  Everyone is permitted to copy and distribute verbatim copies
  of this license document, but changing it is not allowed.

So perhaps that one should be excluded.

Original comment by carlo.te...@gmail.com on 2 Jul 2011 at 5:56

Attachments:

GoogleCodeExporter commented 8 years ago
Thanks Carlo! I have applied your patch. I appreciate your help!

Original comment by bcressey@gmail.com on 3 Oct 2011 at 11:56