search

azchohfi / LottieUWP

UWP port of Lottie(https://github.com/airbnb/lottie-android)
Apache License 2.0
273 stars 45 forks source link

Integrate this implementation in lottie xamarin #1

Closed jzeferino closed 7 years ago

jzeferino commented 7 years ago

@martijn00 created LottieXamarin witch implements lottie for Android, iOS, MacOS and TvOS for Xamarin.

Would be great to have the UWP implementation added there.

What do you think @azchohfi ?

azchohfi commented 7 years ago

The second I pushed this I created the PR. https://github.com/martijn00/LottieXamarin/pull/63 It has already been merged!

JimSEOW commented 7 years ago

@azchohfi I could not wait so I compile and test the Example.Form.UWP. Deploy, but no animaiton :-)

Original in AnimationViewRenderer.cs in Lottie.Forms.UWP await _animationView.SetAnimationAsync(e.NewElement.Animation);

However, in LottieUWP Sample await _animationView.SetAnimationAsync((string)e.NewElement.Animation);

azchohfi commented 7 years ago

I created a sample to help understand how this should be used, but it's very similar to Android.

JimSEOW commented 7 years ago

@azchohfi I did a few days ago, just plug in a UWP project. No Animation. A while ago, I download the whole UWP_sample branch and compile the UWP. Again, no Animation.

In both case, We see the slider, moving it does not lead to anything. Not sure WHY??