azdavis / millet

A language server for Standard ML.
https://azdavis.net/posts/millet
Apache License 2.0
196 stars 12 forks source link

Add completions #29

Closed azdavis closed 1 year ago

azdavis commented 1 year ago

Problem

Millet doesn't offer completions, e.g. when typing val x = List. it'd be nice to mention all the things from the List structure, or even just when typing val x = S we could show String, etc as suggestions.

Solution

Implement completions in the LSP spec.

azdavis commented 1 year ago

Already somewhat implemented: https://github.com/azdavis/millet/blob/4e0bed39cdb0e858cbbf84248537bdd3a01dabcc/crates/analysis/src/lib.rs/#L273-L278

azdavis commented 1 year ago

Done in v0.11.0