azdavis / millet

A language server for Standard ML.
https://azdavis.net/posts/millet
Apache License 2.0
196 stars 12 forks source link

millet-ls does not terminate when closing the editor #32

Closed azdavis closed 1 year ago

azdavis commented 1 year ago

Environment

Steps to reproduce

  1. Launch vs code
  2. Open a sml folder
  3. Observe millet-ls starts in activity monitor
  4. Close vs code

Expected behavior

millet-ls should not be in activity monitor anymore (the process should quit)

Actual behavior

It remains

igorlfs commented 1 year ago

Also having this issue with neovim!

azdavis commented 1 year ago

Fixed in e326ae2cfbe206972a3feddb6c84b3f8977542a3