search

azdle / rust-frontmatter

A Fairly Trivial Wrapper for yaml-rust to Extract Frontmatter from a String Slice (Unstable)
8 stars 1 forks source link

Consider making Yaml enum pub #1

Closed Gozala closed 4 years ago

Gozala commented 4 years ago

Hi,

Parsed data and specifically hash-map (which is what I think what frontmatter would always produce) can not be used without Yaml enum. It also appears that version used here is pretty out of date, which in turn requires ensuring that there is no mismatch between yaml-rust added to dependencies and one used by this library.

I would propose making Yaml enum pub so users do not need to deal with additional deps.

softprops commented 4 years ago

I just hit this problem the latest yaml-rust is not compatible with this crate. One alternative would be to push a release making it so. Another would be to re-export Yaml. If this lib is aiming for low maintenance, re-exporting Yaml would probably be best

azdle commented 4 years ago

I've published 0.3.1 that re-exports Yaml so you can use it directly and I've also published 0.4.0 that then updates to yaml-rust 0.4.

I've given this library basically zero thought since I first published it 4 years ago as a learning exercise, there's probably lots that could be improved about it. PRs are very welcome if anyone wants to improve it.

softprops commented 4 years ago

@azdle thanks!

softprops commented 4 years ago

4 years... It still works great