search

azer / prova

Test runner based on Tape and Browserify
Other
333 stars 30 forks source link

harmony #30

Closed alfredwesterveld closed 10 years ago

alfredwesterveld commented 10 years ago

Could the prova binary be enhanced to use harmony (--harmony) like node --harmony

azer commented 10 years ago

@alfredwesterveld do you have specific reason to not run the tests with node command? like:

node test
alfredwesterveld commented 10 years ago

Wow azer you respond quickly. node test? I can run single test file using node . This does however not work if I want to run all tests? I used your provided prova binary(npm -g) to run all test but this does not work when using enhancements provided by harmony(--harmony). I am running node v0.11. I would like to pass in these arguments if possible.

azer commented 10 years ago

I'm not sure how to implement it, any examples ideas ?

alfredwesterveld commented 10 years ago

I am going to look if I can implement this myself after I read your code. But what needs to happen is that I should be able to parse extra arguments which are not swallowed. Mocha also recently added this option because visionmedia(others) were also using harmony extensions(koa). I try to locate that commit.

azer commented 10 years ago

let's keep the issue open until we solve the issue

alfredwesterveld commented 10 years ago

https://github.com/alfredwesterveld/prova/commit/7b2b5e79ce97ae341afd64054a84eef04bd2cf7a is a quick fix so that I can use harmony by spawning a new process which got harmony arguments passed in.

alfredwesterveld commented 10 years ago

I also fixed this another way(Just came up with this) which does not require any code change. I added the following to my .bashrc:

bash alias p='node --harmony /home/alfred/nodejs/node-v0.11.10-linux-x64/bin/prova'

now I use p which points to your prova bin with added necessary flag.

alfredwesterveld commented 10 years ago

I think this one can be closed now?

azer commented 10 years ago

sure thx

alfredwesterveld commented 10 years ago

Haha no thank you ;). Should have not opened this issue, but think it a little bit more through :$... On the other hand I hope other people might find this helpfull....