search

azer / prova

Test runner based on Tape and Browserify
Other
333 stars 30 forks source link

Having browser send down raw TAP output as well #42

Closed aghassemi closed 9 years ago

aghassemi commented 9 years ago

Fixes https://github.com/azer/prova/issues/39 by allowing browser to send down raw TAP output so --tap can now work with --browser.

aghassemi commented 9 years ago

Calling tape.createStream() twice as I have in this PR seems to have a side-effect where for the very first test in the suite, the state of whether it has ended or not is ignored making t.plan(x) not work properly in the first test. Probably related to how tape dequeues on every createStream() call. I am closing this PR until I find a solution either here or in tape for this problem.

aghassemi commented 9 years ago

Found a work-around for the tape behavior where calling createStream() more than once causes weird side-effects on the very first test in the suite. The work-around is not ideal as it accesses private tape variables however.

aghassemi commented 9 years ago

https://github.com/substack/tape/issues/105 tape.

aghassemi commented 9 years ago

Closing in favour of https://github.com/azer/prova/pull/45