Closed joeybaker closed 9 years ago
hmm, I ran it on bunch of projects and didn't have any issue. Looks like an issue about the crypto package
btw you can try rm -rf node_modules/prova
Huh. I just did a clean install of prova, and the problem did not go away. Somewhat interestingly, the error shows up twice per test run.
Here's the script we're using to run prova:
./node_modules/.bin/prova ./test/lib/*-test.js -b -e -l chrome -t hbsfy
yeah, I actually started getting the same error. https://github.com/azer/prova/pull/53 upgraded browserify, some new settings are messed up as I see. any ideas @TheAlphaNerd ?
@joeybaker just published a patch as 1.16.1, does it fix ?
@TheAlphaNerd were these options necessary? https://github.com/azer/prova/commit/f805b23b4c95d2eaf716de928aabab08ac86ec47
I believe those options are necessary for watchify
I know that dominic tarr just updated crypto-browserify 3 hours ago... I'm digging in to see if this could be causing it
@TheAlphaNerd I was getting different path errors though
try ./node_modules/prova/bin/prova test
instead of global prova, that's how I reproduced the issue
I have chased it down to the updated version of crypto-browserify.
if you manually cd into `node_modules/browserifyand
npm install crypto-browserify@3.3.0`` then all is well in the universe
I'm going to run some diffs and see if I can chase down the error
This is breaking across all of browserify right now.
@azer you probably want to roll back the changes that you made to 0.16.1 as it will break watchify
Just submitted a fix... hopefully this gets merged quickly https://github.com/dominictarr/crypto-browserify/pull/74
thanks a lot @TheAlphaNerd
reverted & released as 1.16.2
!!!
Thanks @TheAlphaNerd!
Landed https://github.com/dominictarr/crypto-browserify/commit/5efa463d3fbc4c0db9567243855f04e6e1f9125a @azer you can close this issue.
If anyone has this problem try an uninstall / reinstall of prova and the issue should be fixed
great, @TheAlphaNerd thanks a lot
Looks like there's a missing dep?