0.16.0 fails to browserify

joeybaker commented 9 years ago

Looks like there's a missing dep?

prova:browser Failed to browserify the source code. We're probably missing a module required. The error was: +15s

    Cannot find module 'sha.js' from '/…/node_modules/prova/node_modules/browserify/node_modules/crypto-browserify' /…/node_modules/prova/node_modules/browserify/node_modules/resolve/lib/async.js
                        v
    49.         else if (core[x]) return cb(null, x);
    50.         else cb(new Error("Cannot find module '" + x + "' from '" + y + "'"))
    51.     });
                        ^
    Error: Cannot find module 'sha.js' from '/…/node_modules/prova/node_modules/browserify/node_modules/crypto-browserify'

azer commented 9 years ago

hmm, I ran it on bunch of projects and didn't have any issue. Looks like an issue about the crypto package

btw you can try rm -rf node_modules/prova

joeybaker commented 9 years ago

Huh. I just did a clean install of prova, and the problem did not go away. Somewhat interestingly, the error shows up twice per test run.

Here's the script we're using to run prova:

./node_modules/.bin/prova ./test/lib/*-test.js -b -e -l chrome -t hbsfy

azer commented 9 years ago

yeah, I actually started getting the same error. https://github.com/azer/prova/pull/53 upgraded browserify, some new settings are messed up as I see. any ideas @TheAlphaNerd ?

azer commented 9 years ago

@joeybaker just published a patch as 1.16.1, does it fix ?

@TheAlphaNerd were these options necessary? https://github.com/azer/prova/commit/f805b23b4c95d2eaf716de928aabab08ac86ec47