azer / prova

Test runner based on Tape and Browserify
Other
332 stars 30 forks source link

upgrade package dependencies #68

Open bySabi opened 8 years ago

bySabi commented 8 years ago

I update package dependencies to latest and all 7 test passed.

Is a warnnig on the command line:

npm WARN prova@2.1.2 license should be a valid SPDX license expression

that can be solved is you choose another, more specific, BSD license

azer commented 8 years ago

could you try it on browser, too ? node test -b

bySabi commented 8 years ago

a something more is need cause node test -b not work even on master branch:

.... ~/Documents/Projects_git/WIP/prova on master [!]
$ node test -b
/Users/.../Documents/Projects_git/WIP/prova/lib/browser.js:35
var onSourceCodeChange = require("pubsub")();
                                          ^

TypeError: require(...) is not a function
    at Object.<anonymous> (/Users/.../Documents/Projects_git/WIP/prova/lib/browser.js:35:43)
    at Module._compile (module.js:541:32)
    at Object.Module._extensions..js (module.js:550:10)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/.../Documents/Projects_git/WIP/prova/index.js:26:3)
    at Module._compile (module.js:541:32)
azer commented 8 years ago

that should be fixed now

bySabi commented 8 years ago

Yes! is fixed! Test on upgrade branch passed on browsers too:

 Visit http://localhost:7559 to run the tests

  4 passed assertions.
  Browser: Chrome v51 Engine: WebKit v537.36 OS: Mac OS v10.11.5

  4 passed assertions.
  Browser: Firefox v47 Engine: Gecko v47.0 OS: Mac OS v10.11