search

azerbini / eamena_dev

Arches is a web-based, geospatial information system for cultural heritage inventory and management.
GNU Affero General Public License v3.0
1 stars 2 forks source link

Missing fields from E24 #35

Open AzadehVafadari opened 6 years ago

AzadehVafadari commented 6 years ago

2 fields are missing from E24:

1. Secondary Threat (Secondary_Threat_Type.E55) is missing from Step 2 Risk, threat and risk identification (in Branch structure E24 condition assessment issue, may 10th I had mentioned: Threat and Risk Identification should include Threat (Threat_Type.E55) Potential Impact (Potential_Impact_Type.E55) Secondary Threat (Secondary_Threat_Type.E55)

2. Feature Current Use (Heritage_Feature_Use_Type.E55) Should be after name and classification. Current_use.pdf

From E24 User Interface sheet:

Feature Summary · Name (Name.E41) & Name Type (Name_Type.E55) · Heritage Feature Classification (Heritage_Classification_Type.E55)
· Current Use (Heritage_Feature_Use_Type.E55) · Designation Type (Designation_Type.E55) & Designation Date (from & to dates, Designation_From_Date.E61 & Designation_To_Date.E61) · General Description (General_Description.E62) & Description Type (General_Description_Type.E55)

mradamcox commented 6 years ago

Hey @AzadehVafadari,

  1. @azerbini finished this work up as I continued to have trouble managing the branching structure of the graph. I was just checking it out, and that node input does appear in the code, but is commented out, so there may be more to the story
  2. I see Current Use in the Feature Interface sheet you mentioned, but it is not present in the E24 graph/ontology, so I didn't add it in my initial work on that user interface.
AzadehVafadari commented 6 years ago

Hi @mradamcox realized I hadn't replied here. Current Use is in the graph. Under production branch image

can you add it here in Resource Summary? or does it have to be under modification and construction?

azerbini commented 6 years ago

@AzadehVafadari, 9984bba introduces Current Use. However Secondary Threat is causing problems. There appears to be a conflict between Threat Type and Secondary Threat Type, possibly due to the graph structure. I don't think it is a high priority to reintroduce Secondary Threat, so I will leave this as is for now.

AzadehVafadari commented 6 years ago

Thanks Andrea. Can I do anything to fix the problem with the graph structure? Would be good to keep this feature! But if we think it’s not a priority now, is there a list where we keep track of “unsolved issues” for Mike and you all to try to fix after the first launch? Thanks

azerbini commented 6 years ago

Azadeh, this issue will stay open until eventually we fix it.

Sent from my iPhone

On 13 Sep 2018, at 08:07, AzadehVafadari notifications@github.com<mailto:notifications@github.com> wrote:

Thanks Andrea. Can I do anything to fix the problem with the graph structure? Would be good to keep this feature! But if we think it’s not a priority now, is there a list where we keep track of “unsolved issues” for Mike and you all to try to fix after the first launch? Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/azerbini/eamena_dev/issues/35#issuecomment-420906095, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASWgd6PEIeMPRYao06dIkl5KW3gpKM-hks5uagQMgaJpZM4VD7-s.