Properly handle `x` values in Excelreader for all data types

azerbini / eamena_dev

Arches is a web-based, geospatial information system for cultural heritage inventory and management.

GNU Affero General Public License v3.0

1 stars 2 forks source link

Properly handle `x` values in Excelreader for all data types #50

Closed mradamcox closed 5 years ago

mradamcox commented 5 years ago

User Story

Currently, excelreader validation fails on date values that are recorded as x. These values are valid, they just need to be skipped and interpreted as empty. In fact, for nodes of any business table type, x just means "empty", not only for concept data types, which was the assumption in the latest revision of the validation code.

This change also needs to also be reflected in the .arches writing commands.

mradamcox commented 5 years ago

This should be solved now and can be tested in the published al ula instance.

azerbini commented 5 years ago

Actually @mradamcox , this is still not working

mradamcox commented 5 years ago

oh, I see what's going on now, the values aren't properly split during this validation operation. I'll push a fix momentarily.

mradamcox commented 5 years ago

https://github.com/azerbini/eamena_dev/commit/b89a80bd9a33ec373849d3c1a6749cb47fff3420 fixes this.