search

azerbini / eamena_dev

Arches is a web-based, geospatial information system for cultural heritage inventory and management.
GNU Affero General Public License v3.0
1 stars 2 forks source link

Bulk upload - missing geometries not flagged up during validation #90

Closed pascalflohr closed 5 years ago

pascalflohr commented 5 years ago

When validating bulk uploads (at least for E24 feature) two missing lines of geometry were not flagged up.

pascalflohr commented 5 years ago

In the Al Ula database, but presumably the same in EAMENA v2

mradamcox commented 5 years ago

@pascalflohr could you be more specific about missing? One big drawback of the bulk upload validation is that it does not check for fields that are "required" through the input forms. So that could be related to what you're seeing with the geometry (or not!). Just wanted to check that first...

pascalflohr commented 5 years ago

@mradamcox yes that could be it. It is when the complete line is missing. I had understood that we should always put 'x'es as placeholders, so that other values cannot shift into these places. If this is not flagged up, people might miss this. In this case, would the geometries of line 51 shift to other records, or would the geometries simply be empty? In the latter case it is not such a problem, in the former it would be.

screen shot 2019-01-15 at 15 10 20

mradamcox commented 5 years ago

@pascalflohr yes, I see now, indeed I think this empty cells should have been caught. I'll look into it. Thanks for the screenshot.

mradamcox commented 5 years ago

@pascalflohr I have pushed a fix to the al-ula server which will hopefully address this. Can you please test it whenever you get a chance? thanks!

pascalflohr commented 5 years ago

@mradamcox the bulk upload validation now seems to get stuck after testing the headers:

screen shot 2019-01-15 at 21 53 09

not going further after this

pascalflohr commented 5 years ago

@mradamcox any news on this? Would it be possible to set it back to the previous state please, as we cannot validate or load at the moment?

mradamcox commented 5 years ago

Ok, I think I have the right fix now. Sorry about the delay.

pascalflohr commented 5 years ago

excellent news, many thanks!

pascalflohr commented 5 years ago

@mradamcox unfortunately my bulk upload still does not seem to get through, it checks the headers, but afterwards the wheel just keeps spinning without anything happening.

mradamcox commented 5 years ago

hm, would you be able to send me the file you are trying to upload? e-mail or attaching here, whatever works for you.

pascalflohr commented 5 years ago

here is one

same problem for E27s and with several different files

mradamcox commented 5 years ago

Ah, it has to do with arabic characters that I didn't have in my test file I was using locally. Sorry about that. I'll post a fix soon.

mradamcox commented 5 years ago

Fix applied.

pascalflohr commented 5 years ago

excellent, that is all working again and blanks are being flagged up. Thank you @mradamcox!