search

azerbini / eamena_v3

The EAMENA project maps cultural heritage across the Middle East and North Africa
http://eamena.arch.ox.ac.uk
0 stars 1 forks source link

Group Geometry - Limit search results list by group geometry #65

Open azerbini opened 6 years ago

azerbini commented 6 years ago

Currently, if I am part of a group with geometric restrictions, I am still returned all the sites in the database as a list of search results, but the ones lying outside my area of access return a 403 error when clicked on. These should not appear in the list of results at all.

ahaith commented 6 years ago

Aha, I remember now. Being a member of the main edit/view group returns all resources unless there is an area defined. If you set a small triangle somewhere in the sea for these, you will get the desired behaviour.

azerbini commented 6 years ago

@ahaith No, this doesn't seem to work. I added region-wide geometries to both edit and editplus. Then, I have a user which can only access geometries in a portion of Tunisia (and is not part of either edit or editplus, but only of a group with access to Tunisian records). The latter will still get the full list of Tunisian search results, and get 403 when clicking on sites lying outside of the geometry specified in his group.

ahaith commented 6 years ago

OK, will investigate on Monday. It might be useful for you to come over at some point early in the week if you have any free time?

Some good news: I have the tunisia shape you gave me successfully filtering the right resources from elasticsearch (after tweaking the kml file contents slightly).

Cheers, Andy

From: Andrea Zerbini [notifications@github.com] Sent: 10 November 2017 18:00 To: azerbini/eamena_v3 Cc: Andrew Haith; Mention Subject: Re: [azerbini/eamena_v3] Group Geometry - Limit search results list by group geometry (#65)

@ahaithhttps://github.com/ahaith No, this doesn't seem to work. I added region-wide geometries to both edit and editplus. Then, I have a user which can only access geometries in a portion of Tunisia (and is not part of either edit or editplus, but only of a group with access to Tunisian records). The latter will still get the full list of Tunisian search results, and get 403 when clicking on sites lying outside of the geometry specified in his group.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/azerbini/eamena_v3/issues/65#issuecomment-343543325, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFyynUvPERrxXPXKbAzYuA6wKEkH2AMlks5s1I9KgaJpZM4QWUkG.

azerbini commented 6 years ago

Amazing news about ES! I needed this right before leaving the office :)

I have pushed some commits to admin-panel, have a look.

Have a good weekend!

Sent from my iPhone

On 10 Nov 2017, at 18:09, Andy Haith notifications@github.com<mailto:notifications@github.com> wrote:

OK, will investigate on Monday. It might be useful for you to come over at some point early in the week if you have any free time?

Some good news: I have the tunisia shape you gave me successfully filtering the right resources from elasticsearch (after tweaking the kml file contents slightly).

Cheers, Andy

From: Andrea Zerbini [notifications@github.commailto:notifications@github.com] Sent: 10 November 2017 18:00 To: azerbini/eamena_v3 Cc: Andrew Haith; Mention Subject: Re: [azerbini/eamena_v3] Group Geometry - Limit search results list by group geometry (#65)

@ahaithhttps://github.com/ahaith No, this doesn't seem to work. I added region-wide geometries to both edit and editplus. Then, I have a user which can only access geometries in a portion of Tunisia (and is not part of either edit or editplus, but only of a group with access to Tunisian records). The latter will still get the full list of Tunisian search results, and get 403 when clicking on sites lying outside of the geometry specified in his group.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/azerbini/eamena_v3/issues/65#issuecomment-343543325, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AFyynUvPERrxXPXKbAzYuA6wKEkH2AMlks5s1I9KgaJpZM4QWUkG.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/azerbini/eamena_v3/issues/65#issuecomment-343545604, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ASWgd5YIMLIQp8b4qX-2ckLTPAlgSFKbks5s1JFngaJpZM4QWUkG.