feat: show character icons on shop services

azerothcore / acore-cms

ACore CMS based on Wordpress

https://www.azerothcore.org/acore-cms/

50 stars 31 forks source link

feat: show character icons on shop services #104

Closed IcemanHHW closed 2 years ago

IcemanHHW commented 2 years ago

Issue: https://github.com/azerothcore/acore-cms/issues/96

No CSS has been implemented since I wasn't sure if it was needed for this

https://user-images.githubusercontent.com/20383130/160244618-689d0ec4-40b9-4b4e-be25-0da065524fc0.mp4

Helias commented 2 years ago

Thanks for what you did! Besides the comments above that are pretty minor things, I ask you to find a way if it's possible to improve the alignment of the two picture race/class here

Helias commented 2 years ago

tested, that's not so bad, but two things:

as the screenshot of the issue shows it would be nice to have the list of character under the text "select character"
it is incompatible with item-restoration, because item-restoration overwrite the onchange 😔

I am working on this

Helias commented 2 years ago

done https://github.com/IcemanHHW/acore-cms/pull/1

removing JQuery, the binding of "this" and write in a clean way an item restoration service function make the trick, merge my PR into your branch and we can merge this PR too

P.S. = Good Job