Closed Goatform closed 1 year ago
There's mistake that I've done using ACoreServices::I()->getAccountRepo()
, gonna fix that later on when I have time.
Just putting it out here in case someone was about to comment on it.
There's mistake that I've done using
ACoreServices::I()->getAccountRepo()
, gonna fix that later on when I have time. Just putting it out here in case someone was about to comment on it.
Now, this one should be resolved with 17da5ff
thank you for your contribution!
Before
<
typo and would render the rest of the content that was supposed to fail (not work) anyway.UPDATE: Put all of the stuff within
try
/catch
handler to handle every exception properly instead of doing additional DB checks to see if DB connection is proper etc (also previously you had no global error checks and this will fix it)NOTE: Ideally I'd implement global exception handler for this (admin / dev / local only) instead of handling this stuff for every logic separately.
After
<
at the end ofecho
stringwp_die
(PHP die equivalent) to stop rendering the rest of parts because they will always fail for the most part.__
translation function in case it gets added eventually (won't cause any issues if it doesn't exist and provided text in code would be used as default instead)Here's how it looks after adding those changes:
Branch: master Commit: 50ae8e95e7e2b68ccf1e255ee368a590cf884596