azerothcore / acore-cms

ACore CMS based on Wordpress
https://www.azerothcore.org/acore-cms/
50 stars 33 forks source link

Fixed a small typo and rendering of the rest of the content when database connection would fail in Admin Panel (SettingsController class) #123

Closed Goatform closed 1 year ago

Goatform commented 1 year ago

Before

UPDATE: Put all of the stuff within try / catch handler to handle every exception properly instead of doing additional DB checks to see if DB connection is proper etc (also previously you had no global error checks and this will fix it)

NOTE: Ideally I'd implement global exception handler for this (admin / dev / local only) instead of handling this stuff for every logic separately.

After

Here's how it looks after adding those changes: image

Branch: master Commit: 50ae8e95e7e2b68ccf1e255ee368a590cf884596

Goatform commented 1 year ago

There's mistake that I've done using ACoreServices::I()->getAccountRepo() , gonna fix that later on when I have time. Just putting it out here in case someone was about to comment on it.

Goatform commented 1 year ago

There's mistake that I've done using ACoreServices::I()->getAccountRepo() , gonna fix that later on when I have time. Just putting it out here in case someone was about to comment on it.

Now, this one should be resolved with 17da5ff

Helias commented 1 year ago

thank you for your contribution!