azerothcore / acore-cms

ACore CMS based on Wordpress
https://www.azerothcore.org/acore-cms/
50 stars 31 forks source link

Add removeEmoji function to mail services #91

Closed nicoaravena closed 2 years ago

nicoaravena commented 2 years ago

This PR fix an error ocurred when an item bought from the store goes with an emoji inside the message.

Solution proposed

How to test

Eronox commented 2 years ago

Tested and works fine, however since we can assume everyone is using modern browsers and OS nowadays i'd vote for converting them to unicode to preserve them

nicoaravena commented 2 years ago

I don't know how the client manage the emojis, if works fine all this thing ingame and doesn't broke them, the I can do a new aproach

Helias commented 2 years ago

I would like to merge this asap, because it's a bit urgent, if anyone read this can break the db, we could make the improvement in another PR

nicoaravena commented 2 years ago

@Helias just add your suggestion.