azerothcore / aowow

Database viewer AoWoW adapted for AzerothCore
https://wowgaming.altervista.org/aowow/
33 stars 33 forks source link

[ Bug ]: Wrong Time Format 24 hour format mixed with 12 hour format #54

Open TheSCREWEDSoftware opened 1 month ago

TheSCREWEDSoftware commented 1 month ago

Current Behaviour

https://wowgaming.altervista.org/aowow/?event=64

image

It either should show 24h format only or 12h formart only

22:00 to 23:00 or 10PM to 11PM

Use AzerothCore?

Yes

Steps to reproduce the problem

1 - Go to https://wowgaming.altervista.org/aowow/?event=64 2 - Look at the "Quick Facts" You will the 2 formats combined.

Extra Notes

No response

Operating system

Windows 10 x64

PHP version

Whatever version the page uses.

Browser

Google Chrome

TheSCREWEDSoftware commented 1 month ago

Edit: The time is also wrong (of the event): https://github.com/azerothcore/azerothcore-wotlk/issues/20186

Sarjuuk commented 1 month ago

'dateFmtLong' => "Y/m/d \a\\t H:i A", in localization/locale_xxxx.php should either be [...] h:i A or [...] H:i

i can't find a PM date on wowhead and the internet archive still hasn't recovered, so i guess it's the former format...?

either way .. super minor^^

/e: https://www.wowhead.com/wotlk/event=424 it's [...] g:i A

Helias commented 1 month ago

but then how we should remove the AM/PM format texts? using [...] g:i A ? I compared this aowow with sarjuuk/aowow and it's the same, we should remove it I guess OR change the time and instead of using 24 time format we could use the 12 ones

btw, I agree it's a minor issue

Sarjuuk commented 1 month ago

from https://www.php.net/manual/en/datetime.format.php

g | 12-hour format of an hour without leading zeros (1 - 12)
i | Minutes with leading zeros (00 to 59)
A | Uppercase Ante meridiem and Post meridiem (AM or PM)

and yes, i need to fix that.

Helias commented 1 month ago

Thanks for the interest. I hope to align this repo with yours soon, maybe using the PR of pangol/stevej that is in pending, hope to find the time...