azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.25k stars 2.5k forks source link

Unlearning a profession triggers entire spell list to display on other trainers dialogs. #1116

Open StygianTheBest opened 5 years ago

StygianTheBest commented 5 years ago

SMALL DESCRIPTION: This bug is causing no harm and lives happily in a cobwebbed area of the core code. It triggers the trainer dialog to update with the entire inventory of spells; all seemingly learnable due to their green color. Clicking on any of them produces no response. This bug triggers the spell list update on many of the trainers, but not all of them, which suggests it lies beyond a certain index, but I haven't confirmed.

EXPECTED BLIZZLIKE BEHAVIOUR: The trainer dialog should not change.

STEPS TO REPRODUCE THE PROBLEM:

BRANCH(ES): master

AC HASH/COMMIT: d55c44c

OPERATING SYSTEM: Windows 7/10

MODULES: None

OTHER CUSTOMIZATIONS: None

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/67602276-unlearning-a-profession-triggers-entire-spell-list-to-display-on-other-trainers-dialogs?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
peti446 commented 3 years ago

Still and issue with AC commit: https://github.com/azerothcore/azerothcore-wotlk/commit/003fa8773144dede989e67448bd2ffdee5222d36

When you unlearn a profession while talking to a trainer the low level will update as if you had the profession but you cannot buy any of the recipes because of the required level. More of a visual bug then anything. Proof: image See how even tho I do not have the apprentice it will show recipes in green.