search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.63k stars 2.64k forks source link

Big list of commits to port from other projects [$200] #1141

Closed BarbzYHOOL closed 2 years ago

BarbzYHOOL commented 5 years ago

This is barely formatted, if someone from the team wants to edit this and make it look organized and clean, go on.

This is a list of commits to port from other projects (mangos, trinity, or any core in fact).

SUNWELL CORE (Maczuga's)

TRINITY CORE

Not classified :

IMPORTANT:

MINOR - EASY TO ADD :

DALARAN CORE

OTHERS

Got idea from Fall1n who has done it on SunwellCore in his private core https://www.reddit.com/r/wowservers/comments/8u1s8i/spell_attro_cu_fake_delay_does_it_work_only_on/e1c2ol6/ https://bitbucket.org/lukaasm/hellground-wowemu/commits/d09c115242ee9f57da7eed11e8c764f7faeb2f70

On a firestorms leak (legion/mop) like DynastyCore

https://github.com/vmangos/core/commit/b53a0f10b77a8a46d5621c4ca8ee4614553cc516 it's already possible ingame but the command is rather complex, i don't remember it exactly

--- There is a **[$200 open bounty](https://www.bountysource.com/issues/67930495-big-list-of-commits-to-port-from-other-projects?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
FrancescoBorzi commented 5 years ago

@BarbzYHOOL I think it would be more useful to have them split in separate issues; which can be single or grouped by feature

BarbzYHOOL commented 5 years ago

Yeah but it's better than sitting in my computer.

Nefertumm commented 5 years ago

For this commit https://github.com/TrinityCore/TrinityCore/commit/a1f2f30c145f6ad9c4baeffeff32618e71ff537c add this one too https://github.com/TrinityCore/TrinityCore/commit/2ff76e828f7c757b5120aba41947a6d63e082e17

Nefertumm commented 5 years ago

https://github.com/TrinityCore/TrinityCore/commit/d922bc936bd2109bf6332dd84a0d4d31c2b2cba5 -> This commit was reverted by Trinity They put this instead -> https://github.com/TrinityCore/TrinityCore/commit/7dfd472f8dff6ce067572e2887c2beb56d9ba9de

BarbzYHOOL commented 5 years ago

Feel free to edit the issue with ur new findings nefertumm (since you already edited once :P)

retrydev commented 5 years ago

Maczuga/SunwellCore@9fb7429

(((- Core/Creature: Fix health regeneration. Creatures immediately reset to full health upon reaching home, rather than slowly regaining it over multiple seconds, which allows players to re-engage them at less than max health.)))

Do not apply this commit, otherwise you will see a buggy hp in princes in ICC

FrancescoBorzi commented 5 years ago

yes... be careful about what you import

Viste commented 5 years ago

for TrinityCore/TrinityCore@59db2ee Better blizzlike NPC / GOB spawning

need also include all fix commits >_<

ADDED TO THE ORIGINAL POST

FrancescoBorzi commented 5 years ago

can we split this in separate issues and assign them to https://github.com/azerothcore/azerothcore-wotlk/milestone/5 ?

BarbzYHOOL commented 5 years ago

Here are more of them I had noted long ago:

IMPORTANT - HARD TO ADD : https://github.com/TrinityCore/TrinityCore/pull/18771 NOT MERGED YET BUT SEEMS RATHER IMPORTANT

IMPORTANT - MEDIUM : https://github.com/TrinityCore/TrinityCore/pull/19914 https://github.com/TrinityCore/TrinityCore/pull/19767/files (LOTS OF FILES BUT EASY TO ADD)

IMPORTANT - EASY TO ADD : https://github.com/TrinityCore/TrinityCore/pull/19906

MINOR - EASY TO ADD : https://github.com/TrinityCore/TrinityCore/pull/20305/commits/6b226cf735e23bdb40c2dcaba644e0ebbb620cb2 https://github.com/TrinityCore/TrinityCore/pull/19438 NEED TO SEE IF IT BREAKS OTHER SPELLS https://github.com/TrinityCore/TrinityCore/pull/19055/files https://github.com/TrinityCore/TrinityCore/commit/62f7debffdb0a45cec0744ddb29460214febc9b8 https://github.com/TrinityCore/TrinityCore/commit/1a6d0b8d951534754c5a82a7a861f415c1b2f2ca https://github.com/TrinityCore/TrinityCore/commit/4d654f548b29bf61552d9f90da8254ecea91b63e https://github.com/TrinityCore/TrinityCore/commit/015c6b56e965d3c7f80d5109915237482c631b03

For neutral guard AI? : https://github.com/TrinityCore/TrinityCore/pull/20202/commits/f455d9db1f9e461cb0090ddd4d95f40a2edac11d

Add missing parameter TARGET to smart_scripts : https://github.com/TrinityCore/TrinityCore/pull/19352/files

Core/Creature: implement automatic distance correction for melee combat https://github.com/TrinityCore/TrinityCore/pull/21282/

Core/Movement: Using player position extrapolation to smooth range checks https://github.com/TrinityCore/TrinityCore/pull/18128

Core/Movement: Improve player movement https://github.com/TrinityCore/TrinityCore/pull/18771

Core/Movement: Correct the allowed distance to target before a repositioning is necessary. https://github.com/TrinityCore/TrinityCore/pull/21193

Better grouphandling Modify group invite behavior while creating group to be blizzlike: https://github.com/TrinityCore/TrinityCore/commit/132538db1dfb3c495294eeb5acfead59dea02b5c

Got idea from Fall1n who has done it on SunwellCore in his private core https://www.reddit.com/r/wowservers/comments/8u1s8i/spell_attro_cu_fake_delay_does_it_work_only_on/e1c2ol6/ https://bitbucket.org/lukaasm/hellground-wowemu/commits/d09c115242ee9f57da7eed11e8c764f7faeb2f70

Zeppelin See this PR https://github.com/azerothcore/azerothcore-wotlk/pull/907 () removed gossip menu options 1969 and 1971 - need to put them back with missing zeppelin master gossip menus) https://github.com/Falstring/Dalaran-Core/blob/3605a709de0b6b73c05dcb0bd2eb772d7b0bcf86/src/server/scripts/World/zeppelins.cpp

ADDED TO THE ORIGINAL POST

FrancescoBorzi commented 5 years ago

https://github.com/TrinityCore/TrinityCore/commit/469f2d3ade168de0b5be18112008c337067a8e03

BarbzYHOOL commented 5 years ago

@FrancescoBorzi plz add it to the original post and mark the obsolete comments as resolved (click on Hide) I don't know what your commit is for lol

Viste commented 5 years ago

reopen plz

FrancescoBorzi commented 5 years ago

A big bounty (150 dollars) has been posted from our @heyaapl, for which I'm very thankful.

We need to do the following: go to the list and filter the imports that we are really sure that can and should be imported. Completing such imports will be the criteria to earn the bounty.

ghost commented 4 years ago

On the commit TrinityCore/TrinityCore@6b226cf the worldserver is a tad different from what we have on azerothcore so further research is required to add this feature or implement it without their changes.

ghost commented 4 years ago

https://github.com/TrinityCore/TrinityCore/pull/19055/files This is already implemented, should tick the checkbox

ghost commented 4 years ago

commit Maczuga/SunwellCore@7b1945a also already present on the database table quest_template_addon

BarbzYHOOL commented 4 years ago

I added another one to the list that is about making the waypoint transition smooth (instead of a sudden change of direction)

Note: that the author Ovahlord seems to make really cool stuff :P Maybe can find more in these https://github.com/TrinityCore/TrinityCore/pulls?q=is%3Apr+author%3AOvahlord+is%3Aclosed

BarbzYHOOL commented 4 years ago

Not added to the list yet but here is a list of several commits, suggested by the great Jackpoz https://github.com/azerothcore/forum/issues/24#issuecomment-594810696

If someone adds it to the list, delete or edit this comment

Helias commented 4 years ago

This big list of commits is really huge, I don't think that it's easy to do at all.

If split this issue in multiple issues, and reduce the amount of this epic issue only on the "SUNWELL CORE (Maczuga's)", I can try to port them all. The bottom issues seem very big and difficult (like Clustering or CROSS-realm), the TC ones are almost done or closed PRs, may we can move all the TC commits into another issue and put a bounty of 100$ on it and move the bottom ones into another issue.

What do you think? @BarbzYHOOL @Yehonal @FrancescoBorzi @Knindzagxg @Kitzunu

ghost commented 4 years ago

I agree with @Helias though I wasnt asked. It just seems like a huge list and much more than doing extra posts for each section.

Helias commented 4 years ago

bump

FrancescoBorzi commented 3 years ago

I've removed the bounty from here so we can open separate issues and assign the bounties on them accordingly.

Suggestions are welcome.

ghost commented 3 years ago

@FrancescoBorzi SkilLineAbility.dbc can be ticked

FrancescoBorzi commented 2 years ago

closing to move the bounty elsewhere as this is not going anywhere specific