azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.47k stars 2.59k forks source link

First Aid trainers in Major Cities telling new characters to go and learn Master First Aid from Books/distant deprecated trainers #11599

Open Contrubius opened 2 years ago

Contrubius commented 2 years ago

What client do you play on?

enUS

Faction

Content Phase:

Current Behaviour

First Aid Major City trainers in Horde:

Arnok located at the Valley of Spirits in Orgrimmar, on the west side (34, 84.4).

Arnok

Alestus in Silvermoon.

WoWScrnShot_050222_151607

Alliance: Nissa Firestone in Ironforge.

WoWScrnShot_050222_151237

Shaina Fuller in Stormwind.

WoWScrnShot_050222_151104

use wrong dialogue on first interaction with the player, pointing him to further training from the start. Upon further researching, the pointers they are giving are supposedly deprecated since patch 3.1.0 when Major City trainers were given the opportunity to fully train players in First Aid from 1 to 300 skill, not needing any Books or distant trainers in Theramore or similar locations to learn First Aid above skill level 225 as it was the case before patch 3.1.0 in WOTLK.

Checking WoWHead and WoWWiki for pointers I figured that Doctor Gregory was only relevant during the Vanilla/TBC/very early WOTLK era and after Patch 3.1.0 (14-Apr-2009): Artisan First Aid may now be trained from any First Aid trainer in a capital city; this quest is no longer required to learn it. Upon completing this quest, you will instead receive 20 [Heavy Runecloth Bandages] and an [Alliance Trauma Certification]. Meaning the dialogue should probably be removed all together as the Orgrimmar or any other Major City trainer can train your skills all the way up to 300 and no books or additional trainers are needed, and the text Arnok was saying before 3.1.0 is misleading now as he can teach all the Vanilla First Aid recipes.

Before the patch, player could learn First Aid up to the skill of 150 in Major City, and after that had to rely on books or special trainers after 225.

All other First Aid trainers have correct gossip, like here in Exodar for example: WoWScrnShot_050222_151324

Expected Blizzlike Behaviour

Mentioned trainers should not be giving further directions for Master First Aid training and should just say "I can train you in First Aid Techniques" on interaction.

Source

3.1.0 Patch note stating the Triaging quest is no longer needed for Artisan First Aid on 225: Gregory not needed

Patch note 3.1.0. stating Major City trainers can now learn player everything they need up until the skill level of 300: First aid reading

Steps to reproduce the problem

  1. Interact with any of the mentioned First Aid trainers.
  2. See they have wrong gossip on interaction.

    Extra Notes

Originally reported: https://github.com/chromiecraft/chromiecraft/issues/3450

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/49191da0f8566a513a7313fa8215e67c7cb996ab

Operating system

Windows 10.

Modules

Customizations

None

Server

ChromieCraft

acidmanifesto commented 2 years ago

I'm famliar with this issue. It originally was a wip pr that a former staff marked for merging when it was never suppose to be merged, this was a while back. It was originally marked wip and not to be merged but ended up getting merged entirely for some unexplained reason. The issue in this case was needing further research so we only had partial conditions made. I will look for the pr itself and see what we can do in "reverting" it.

Pr found: https://github.com/azerothcore/azerothcore-wotlk/pull/10499

Contrubius commented 2 years ago

I'm famliar with this issue. It originally was a wip pr that a former staff marked for merging when it was never suppose to be merged, this was a while back. It was originally marked wip and not to be merged but ended up getting merged entirely for some unexplained reason. The issue in this case was needing further research so we only had partial conditions made. I will look for the pr itself and see what we can do in "reverting" it.

Pr found: #10499

I see, very interesting, I tried to find some referencing dialogue, but only found the one I quoted above in my report. All the books trainers used to recommend, as well as further training from 225 to 300 got merged to all First Aid trainers in Major Cities, making books/other trainers obsolete, I have no sources except for the Patch notes in 3.1.0. for the First Aid and Triaging quest.

BeefSteaker commented 1 year ago

looking through old bugs, this one appears to be blizzlike

current implementation is how it works on wrath classic image