azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.62k stars 2.64k forks source link

Noggenfogger Elixir effect may disable AA #11719

Open Si1ker opened 2 years ago

Si1ker commented 2 years ago

Originally reported by Sílker at https://github.com/chromiecraft/chromiecraft/issues/3495

Current Behaviour

Noggenfogger has the chance to disable auto-attacks.

When you drink Noggenfogger Elixir you have the chance to get one of the following three effects:

You feel light You feel smaller You've stopped breathing

The third one, once you turn into a skeleton, has a low-rate bug (it is not a 100% reproducible bug), it may disable your auto-attacks until you log back into the game. For personal testing, I'd say a 20% repro-rate.

The first and second effects have not triggered this bug in 100 tests. Only the third one.

Note: /startattack , does not work when you're affected by the bug.

Tested in chromiecraft after latest update 5/11 on c7f74e5

https://user-images.githubusercontent.com/61223313/167906947-a5cd84e4-f623-4c99-8b04-c173ac0b9eb4.mp4

Expected Blizzlike Behaviour

You've stopped breathing - Aura 16591 shouldn't have the chance to disable your auto-attacks

Source

Is not planned for an esthetic potion to break your gameplay

Steps to reproduce the problem

.add 8529 100

Drink 'till you get the aura 16591 -> try AA to a target Were you able to attack?

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/c7f74e563758241e29721e95b86aed0093a8856a

Operating system

Ubuntu 20.04

Custom changes or Modules

N/A

UltraNix commented 1 year ago

@Si1ker Still a bug? I remember I fixed something very similar bug.

Si1ker commented 1 year ago

@Si1ker Still a bug? I remember I fixed something very similar bug.

@UltraNix As far as I know, yes it's still present in fresh acores

UltraNix commented 1 year ago

Tried with 100 elixirs - no bug.

Si1ker commented 1 year ago

Thanks for the input @UltraNix will close and reopen if I ever heard about it again.

Never6 commented 1 year ago

this is still an issue btw, would appreciate if this got reopened

https://www.youtube.com/watch?v=D7qPXbcppzg&ab_channel=TheNever

Never6 commented 6 months ago

Tried with 100 elixirs - no bug.

test better then

heyitsbench commented 4 months ago

Consistent reproduction steps found. Make a macro with the following:

/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
/use Noggenfogger Elixir
.additem 8529 50

Use .cheat cooldown, get into combat with a mob, cast an uber heal spell on it, and start using the macro (no need to spam).

heyitsbench commented 4 months ago

I have tested it a little bit, the client does not seem to be sending the start swing packet once this bug takes effect, so it's not like the core is getting caught up in some bad evaluations for that process like I suspected at a glance.

EDIT: Relogging undoes the behavior, at the moment I suspect a bad cast state or similar is being sent to the client somewhere.

heyitsbench commented 4 months ago

This still seems to be an issue, tested by Jedbouk on the CC Discord server.