azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.56k stars 2.63k forks source link

[NPC/dialog/gossip] `Loh'atu` believes we already have helped him #11913

Open Synful-Syn opened 2 years ago

Synful-Syn commented 2 years ago

Current Behaviour

If you didn't complete any of Loh'atu's quests, you will get the following gossip and dialog options.

image

Expected Blizzlike Behaviour

He should have the following gossip if you didn't help him out.

Greetings, < class >. Those Sentinels over there have allowed me to share their camp as long as I promise no trouble will follow—I am sure you can appreciate the need for diplomacy while here, yes? I am here investigating disturbances to the land, and since it aids their cause also, they have agreed that my presence here could only aid the tenuous alliance between all of Azeroth's races. If you with to aid me, then I would appreciate it, but regardless, please try not to cause any trouble.

https://wowpedia.fandom.com/wiki/Loh%27atu

He shouldn't have any dialog options until you have completed both of his quests.

This guy can tell you abit of the history of Azshara if you do his quests ;)

https://www.wowhead.com/npc=11548/lohatu#comments:id=52767

Source

Sources integrated into Expected Blizzlike Behaviour section above.

Steps to reproduce the problem

.go c 35194

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. 6a6418f23204 2022-05-28 17:12:42 +0200 (master branch)

Operating system

Windows 10 x64

Custom changes or Modules

mod-eluna (no scripts)

Synful-Syn commented 2 years ago

On AzerothCore rev. 14d933eddc57 2022-06-04 09:33:50 -0300 (master branch) (Win64, RelWithDebInfo, Static) With the above's PR, the dialog options has been fixed. However, he still believes we have already helped him despite the fact I didn't complete any of his quests.

He should have the following text when spoken when the player didn't complete his quests.

Greetings, << class >>. Those Sentinels over there have allowed me to share their camp as long as I promise no trouble will follow—I am sure you can appreciate the need for diplomacy while here, yes? I am here investigating disturbances to the land, and since it aids their cause also, they have agreed that my presence here could only aid the tenuous alliance between all of Azeroth's races. If you with to aid me, then I would appreciate it, but regardless, please try not to cause any trouble.

https://wowpedia.fandom.com/wiki/Loh%27atu

image