azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.39k stars 2.55k forks source link

Replenishment aura (57669) generates threat. #12115

Open Gultask opened 2 years ago

Gultask commented 2 years ago

https://github.com/chromiecraft/chromiecraft/issues/3635

What client do you play on?

enGB

Faction

Content Phase:

Current Behaviour

Aura Replenishment (57669) can generate threat towards its source

Expected Blizzlike Behaviour

Replenishment should not generate threat, probably.

Source

I have not been able to find a source for this, so I'm not marking it as Confirmed.

Steps to reproduce the problem

  1. Create 2 characters, both out of combat.
  2. Character A casts spell 57669 on character B.
  3. Character B enters combat.
  4. Character A will enter combat when Replenishment ticks.

Note: Threat will be 0 unless mana is actually restored, but character A will enter combat state regardless.

Extra Notes

https://wowpedia.fandom.com/wiki/Replenishment?oldid=2252513 Paladins: Judgements of the Wise Warlocks: Improved Soul Leech Hunters: Hunting Party Mages: Enduring Winter Priests: Vampiric Touch

Replenishment

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/36f0a7757bde9573262f298aa1eaf6765af8295e

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

avarishd commented 1 year ago

confirm on rev. 6581b07934c2b49cae0a1ecde9e33690d9ecc307 This behaviour is wrong.

https://www.mmo-champion.com/threads/613644-Shadow-Priest-Threat

2008-09-05, They increased tanks threat and gave shadowpriest passive salva in the form of shadowform. Also you will generate less threat due the fact that mana regen from replenish is added to the persons threat not yours.

Replenish should work like Improved Leader of the Pact, threat is added to self, not the source. https://www.wowhead.com/wotlk/spell=34300/improved-leader-of-the-pack#comments

Bear in mind that the healing granted by Imp. LotP is a self-heal. Paladins will not gain mana from Spiritual Attunement by proccing this.

and that the heal's threat goes to the one healed and not me,

Side note: Currently, in AC Imp. LotP does not generate ANY threat to anyone. Each heal should be 100k threat (to Etu) (x0.5 of healed value)

https://user-images.githubusercontent.com/46330494/221431231-3e54793c-9ccf-4e6d-abf2-e2580f7975ce.mp4
Gultask commented 1 year ago

There was another spell, Rapture, I think, where it was wrongly adding threat to the source as well. Same could be said about Revitalize. Hell, if we search through the SpellInfoCorrections NO_THREAT hacks we could have a list of these spells. It'd be good to fix it in core properly once and for all.

balleny commented 1 year ago

would be nice to see this flagged as a higher priority at some point as it affects "common gameplay" (running dungeons) quite a bit and is a generic issue taking place e.g. with replenishment, but also druids innervate generating an abnormal amount of threat currently.

avarishd commented 1 year ago

would be nice to see this flagged as a higher priority at some point as it affects "common gameplay" (running dungeons) quite a bit and is a generic issue taking place e.g. with replenishment, but also druids innervate generating an abnormal amount of threat currently.

Innervate works correctly, 5 threat per mana. (Modification by stance does not seem to work though, when casted from bear form (judging from within the article, if it even applies to innervate)) http://web.archive.org/web/20100426234648/http://www.tankspot.com/showthread.php?47813-WOTLK-Bear-Threat-Values

7866 * 5 = 39,3k

![image](https://github.com/azerothcore/azerothcore-wotlk/assets/46330494/f87cb153-93a1-4508-a7d1-b344fb9a8e6a)
ghost commented 1 year ago

would be nice to see this flagged as a higher priority at some point as it affects "common gameplay" (running dungeons) quite a bit and is a generic issue taking place e.g. with replenishment, but also druids innervate generating an abnormal amount of threat currently.

Innervate works correctly, 5 threat per mana. (Modification by stance does not seem to work though, when casted from bear form (judging from within the article, if it even applies to innervate)) http://web.archive.org/web/20100426234648/http://www.tankspot.com/showthread.php?47813-WOTLK-Bear-Threat-Values

7866 * 5 = 39,3k

That source is some terrible copypasta of an original text saying "50 threat per 100 mana". Mana gains always generated half threat per mana point. 90% of them still do. Only innervate is screwed up because somebody misread a number in a druid spreadsheet. 5 threat per point is only for rage type of power gains.

ghost commented 11 months ago

We just tested this on Classic wotlk with Kerrik and the results show it's working as intended. All threat is added to the caster https://www.youtube.com/watch?v=I0p9ifmIhKA It is possible that this was reworked between 2008 and 2010, since the above comments are older.

heyitsbench commented 8 months ago

I tested this on Classic using a priest (with Vampiric Touch) and a warlock. Both had low mana, replenishment went up, face pulled a mob on the warlock, the priest was not put in combat nor was any threat generated by either character. (Using Tiny Threat to measure threat generated.)