azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.58k stars 2.64k forks source link

Herb loot acting oddly #12286

Open Stump876 opened 2 years ago

Stump876 commented 2 years ago

Current Behaviour

Typically I repeatedly pick an herb node to gain a skill point. I noticed some herbing nodes and not giving skill up points even if they are a color to pick (over 50 tries). Also the amount looted will vary if picked repeatedly image image image image

Expected Blizzlike Behaviour

Chance at skill up per node that is a color. Amount looted should not change until the herb respawns. (no source, but could easily be exploitable for max loot)

Source

https://wowpedia.fandom.com/wiki/Profession#Increasing_professional_skill_level

Steps to reproduce the problem

.go game 63370 or 4239 also does the same for some kingsblood and buriseweed you might need to scout around for existing nodes .setskill 182 192 225 -not working you have to actually train herbalism from the trainer but you can .set skill so level it up click to gather but do not loot

Extra Notes

Noticed on Chomiecraft was able to duplicate on my local

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/0ef7f999db7284c2a7776b70c9ecf008d8551f16

Operating system

windows 10

Custom changes or Modules

Tereneckla commented 2 years ago

Are you seriously able to repeatedly pick on one and the same node and gain skill points? That should not be possible

Stump876 commented 2 years ago

Only one skill point per gathering node and only if it's a color. With the exception of skinning, you can do multplie attempts and multiple people can get a skill point from it, entire raids would do it for mining, but that was patched out in 4.0.1 One person, one point. https://github.com/chromiecraft/chromiecraft/issues/1491#issuecomment-903194332

Tereneckla commented 2 years ago

Where does that say a person can try again? It only says multiple different people can gain a point

Stump876 commented 2 years ago

Alternatively, miners can share a node for a skill-up by not looting the vein.

On the flip side, where does it say only one attempt allowed? If multiple people can try multiple times by not looting the node, why would it not work like that for one person? Addidtionally that is how it currently works. A source would be needed to show it as a bug.

Tereneckla commented 2 years ago

Where does it say more than one is allowed. Also, if the current way actually were blizzlike it would be mentioned in at least one guide out there

neifion-00000000 commented 2 years ago

This functionality is not a bug, you should only get 1 chance per gameobject to gain skillups.

https://www.youtube.com/watch?v=7qYzLF084g8

at the end of that video

Stump876 commented 2 years ago

Thanks for checking for me. Still the looting seems off. If I can pick and re-pick until I get 3. Any info on that?

neifion-00000000 commented 2 years ago

yeah I didn't read the whole issue 14 hours ago I responded to the discord conversation and put my proofs here, you're correct that you shouldn't reroll loot