azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

[ZG][SPELL][SHAMAN] zandalarian hero charm wrong trigger if used with Chain* spells #12383

Closed Markus909 closed 2 years ago

Markus909 commented 2 years ago

Current Behaviour

Using this item with a chain lighthing/heals (shaman) it reduces its spell power for every target damaged by the spell (-17, -17, -17, ...).. If the chain-lighting proc the talent Lightning Ovearload, it also procs double spell power reduction on trinket's bonus .

Expected Blizzlike Behaviour

Use: Increases your spell power by 204 for 20 sec. Every time you cast a spell, the bonus is reduced by 17 spell power. (2 minutes cooldown)

The bonus spell power should be reduced only on cast, even an istant cast, but only on casted spells.

Source

tolltip of trinket -> https://wotlk.evowow.com/?item=19950

Steps to reproduce the problem

  1. equip the trinket
  2. use it to empower your spell power
  3. cast a chain-lightning on multi target.
  4. check the buff counter

Extra Notes

it also remove a stack if the shaman is using Lightning Shield, and be hitted by an enemy.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/35dfcf588f62339c44ff99a3e7e85f0b983ed923

Operating system

windows 10 x64

Custom changes or Modules

mod-ah-bot mod-bg-item-reward mod-cfbg mod-chat-transmitter mod-chromie-xp mod-cta-switch mod-desertion-warnings mod-dmf-switch mod-duel-reset mod-eluna mod-ip-tracker mod-low-level-arena mod-low-level-rbg mod-multi-client-check mod-progression-system mod-pvp-titles mod-pvpstats-announcer mod-queue-list-cache mod-rdf-expansion mod-transmog mod-weekend-xp lua-carbon-copy lua-exchange-npc lua-custom-worldboss lua-level-up-reward lua-recruit-a-friend lua-send-and-bind lua-temp-announcements lua-zonecheck lua-zone-debuff

UltraNix commented 2 years ago

@Markus909 I don't understand the report. -17 is for every target or maybe is multiplicative (-17,-34,-51, etc). If the 1st case, so this is completely blizzlike.

Markus909 commented 2 years ago

@UltraNix the buff counter lower for every target, instead of every spells. So, if i cast chain-lightining and i hit 3 target i get -17*3= -51 spell power bonus.

UltraNix commented 2 years ago

Okay.