search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.64k stars 2.65k forks source link

Triggered Spells put you into combat #13330

Open BeefSteaker opened 2 years ago

BeefSteaker commented 2 years ago

original issue https://github.com/chromiecraft/chromiecraft/issues/3905. confirmed on ptr

Current Behaviour

Triggered spells, like Mage Ignite put both sides into combat when they trigger This leads to a very long combat timer when a mage has living bomb on a target and it crits

Expected Blizzlike Behaviour

Triggered Spells have no influence on the combat timer

Source

https://youtu.be/qavkjivhSkQ?t=696

Here you see the mage leaving combat with a crit of living bomb causing ignite to trigger 1 second ago

Proof that he has the living bomb glyph (ignite on the new target that had a previous casted living bomb on): https://youtu.be/qavkjivhSkQ?t=436

Steps to reproduce the problem

Get 2 characters, 1 of them mage
On the mage learn ignite and living bomb
.add 18970 2
.add 45737
Equip those rings
Learn the Glyph
Duel
Cast Living Bomb
Look at the combat status

Extra Notes

https://wowgaming.altervista.org/aowow/?spell=44457 https://wowgaming.altervista.org/aowow/?spell=12848

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/e6dd5d3e22d92dddc841079f9108275fd0359be1

Operating system

Ubuntu 20.04

Custom changes or Modules

mod-ah-bot mod-bg-item-reward mod-cfbg mod-chat-transmitter mod-chromie-xp mod-cta-switch mod-desertion-warnings mod-dmf-switch mod-duel-reset mod-eluna mod-ip-tracker mod-low-level-arena mod-low-level-rbg mod-multi-client-check mod-progression-system mod-pvp-titles mod-pvpstats-announcer mod-queue-list-cache mod-rdf-expansion mod-transmog mod-weekend-xp mod-instanced-worldbosses lua-carbon-copy lua-exchange-npc lua-custom-worldboss lua-level-up-reward lua-recruit-a-friend lua-send-and-bind lua-temp-announcements lua-zonecheck lua-zone-debuff

BeefSteaker commented 2 years ago

See also https://github.com/chromiecraft/chromiecraft/issues/4072 Revitalize is not flagged as triggered so ticks of the HoT can proc things like clearcasting and puts you into combat in pvp

sassouiabd commented 1 year ago

I can confirm this issue.

heyitsbench commented 3 months ago

No idea if Revitalize is suffering from the same issue per se. Here seems to be the call stack for mage's Ignite entering combat: Call stack