azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.57k stars 2.63k forks source link

Core/BossAI: Bosses do not reset on wipes #15379

Closed Tony931023 closed 1 year ago

Tony931023 commented 1 year ago

Current Behaviour

When you are in the encounter with Halion and you reach the third phase and receive more damage from the players of any of the two kingdoms, for example you bring the corporability to 20%/80% and all the players die when they revive and go from Back to the fight with Halion it stays as if you were in 3rd phase with the corporality that stayed in the previous event and it does more damage to you and it starts to heal itself and it starts to spam every x seconds "Your (or your companion's) efforts have forced Halion further <into/out of> the <Twilight/Physical> realm!"

Expected Blizzlike Behaviour

when dying and starting the event again, it must start normal without maintaining any corporeality from the previous event

Source

https://wowwiki-archive.fandom.com/wiki/Halion

Steps to reproduce the problem

  1. Go Halion
  2. Enter combat and dies in 3rd phase when the corporatability is different from 50/50
  3. revive
  4. enter combat again, lower his health a bit and wait until he starts to regenerate

Extra Notes

This I think gets corrupted when after applying this change #14789 by @Nyeriah

AC rev. hash/commit

6a66b36a5d5cba8bab9fb62e0e0680cd5c94c4ab

Operating system

Ubuntu 20.04

Custom changes or Modules

No response

speedrunz commented 1 year ago

@Nyeriah can you check this one please?

Another issue is in ICC and might be related to the commit:

Kitzunu commented 1 year ago

Can you test the issue by removing commits until you find the faulty one? I have high doubts that https://github.com/azerothcore/azerothcore-wotlk/commit/bf30c66ba48cede909a98cb132959c979c032b3b is the culprit as the bosses themselves are not touched by these changes

Kitzunu commented 1 year ago

@UltraNix perhaps you want to take a look?

UltraNix commented 1 year ago

Perhpas it's not a generic problem, but it's something within the scripts.

Kitzunu commented 1 year ago

Could be. At first it looked generic though.

UltraNix commented 1 year ago

f59ee4ef7cc455fc300ed0741ac635c8e1f03fe3 Check this one

Tony931023 commented 1 year ago

@Kitzunu @UltraNix confirmed, this is corrupted by applying this https://github.com/azerothcore/azerothcore-wotlk/commit/f59ee4ef7cc455fc300ed0741ac635c8e1f03fe3 by @Nyeriah

tested on some bosses:

Halion -> what is said in this issue happens #15379 Lich King-> what is said in this issue happens #15388 Sindagosa -> what is said in this issue happens #15410 Algalon the Observer -> what is said in this issue happens #15382

yukijean commented 1 year ago

@Tony931023 Hey buddy, did you miss out on my # 15382 question?

Tony931023 commented 1 year ago

@Tony931023 Hey buddy, did you miss out on my # 15382 question?

Update https://github.com/azerothcore/azerothcore-wotlk/issues/15379#issuecomment-1474873514

yukijean commented 1 year ago

@Kitzunu @UltraNix @Tony931023 Three brothers, please tell me when the bug in LK Algalon and Cindagosa is expected to be repaired. Thank you.

Nyeriah commented 1 year ago

@yukijean Please don't ping random people and don't ask for things to be fixed. If you'd like to see something fixed without contributing, you may place a bounty on it.

As for this issue, I will address it when I find the time.

yukijean commented 1 year ago

@Nyeriah OK, THANK YOU

Nyeriah commented 1 year ago

https://github.com/azerothcore/azerothcore-wotlk/pull/15507

yukijean commented 1 year ago

Hello, I'm not trying to urge you, but seeing that you have fixed two boss issues that are very serious, I still want to ask, Olgaren, has the issue of not refreshing been resolved in this update? Thank you very much

---Original--- From: @.> Date: Wed, Mar 22, 2023 02:07 AM To: @.>; Cc: @.**@.>; Subject: Re: [azerothcore/azerothcore-wotlk] Core/BossAI: Bosses do not reseton wipes (Issue #15379)

15507

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

heyitsbench commented 1 year ago

Hello, I'm not trying to urge you, but seeing that you have fixed two boss issues that are very serious, I still want to ask, Olgaren, has the issue of not refreshing been resolved in this update?

Doesn't look like it. That issue does need to be reopened, as it was closed for being a duplicate of this one.

yukijean commented 1 year ago

Could you tell me how to reopen it

---Original--- From: "Benjamin @.> Date: Wed, Mar 22, 2023 12:54 PM To: @.>; Cc: @.**@.>; Subject: Re: [azerothcore/azerothcore-wotlk] Core/BossAI: Bosses do not reseton wipes (Issue #15379)

Hello, I'm not trying to urge you, but seeing that you have fixed two boss issues that are very serious, I still want to ask, Olgaren, has the issue of not refreshing been resolved in this update?

Doesn't look like it. That issue does need to be reopened, as it was closed for being a duplicate of this one.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

yukijean commented 1 year ago

@Tony931023 Hello, did you see the last 10% or so of the time when you tested the Lich King again, and the NPC disappeared without triggering the plot. In P3, the previously disappeared floor was restored~~

Tony931023 commented 1 year ago

Hello, did you see the last 10% or so of the time when you tested the Lich King again, and the NPC disappeared without triggering the plot. In P3, the previously disappeared floor was restored~~

I'll try that later now

yukijean commented 1 year ago

Thank you very much. If the test is complete and convenient, you can reply and observe that the terrain lost on P2 will be restored on P3, and then 10% NPC will disappear.

yukijean commented 1 year ago

@Tony931023 #15542 15542,Hello, you have time to watch. Someone uploaded a video and encountered the same problem.

yukijean commented 1 year ago

@Tony931023 #15542 15542,Hello, you have time to watch. Someone uploaded a video and encountered the same problem.