azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.39k stars 2.55k forks source link

Hand of Reckoning triggering grounding totem #15398

Open BeefSteaker opened 1 year ago

BeefSteaker commented 1 year ago

https://github.com/chromiecraft/chromiecraft/issues/5170

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

hand of reckoning https://www.wowhead.com/wotlk/spell=62124/hand-of-reckoning triggers grounding totem https://www.wowhead.com/wotlk/spell=8177/grounding-totem

Expected Blizzlike Behaviour

Hand of Reckoning shouldnt trigger or destroy grounding totem, esp not when the spells target is targeting the paladin.

Source

Tested on WotLK Classic PTR (48503). AvA duel, HvA PvP.

Steps to reproduce the problem

one on char; .learn 62124 on second char .learn 8177

duel

Extra Notes

Before patch 3.2.0 the ability was commonly used to destroy totems because it had a direct damage component that was independent

https://www.mmo-champion.com/threads/645823-PvP-Hand-of-Reckoning

actually it still keeps players in combat, the real issue is now it does not kill totems

Further

but damage done increased to 50% of attack power, occurring after the taunt effect is applied.

As players are immune Hand of Reckoning shouldnt trigger Grounding Totem or e.g. Warriors Spell Reflect.

Also: there was already a ticket in AZ https://github.com/azerothcore/azerothcore-wotlk/issues/626 this ticket states that HoR was explicitly not killing totems. This got changed based on the assumption of an macro found online. Tho, this macro will likely refer to times before patch 3.2.0. as it was commonly used before that to destroy totems (see first quote in this section).

Overall, it should be easily verified on wotlk classic ptr (i do recommend to test it twice, once with the shaman targeting the paladin, and once without)

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/03d47897ece3e0a615aac05222d9fbd98b33717d

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

UltraNix commented 1 year ago

Cannot reproduce it.

avarishd commented 2 months ago

Couldn't reproduce either.

https://github.com/azerothcore/azerothcore-wotlk/assets/46330494/adcf2b5e-505a-4c2f-b522-cd35f6d4c138