azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.56k forks source link

(ICC) bug Gunship Battle not crossfaction ready #15872

Open Fireevil opened 1 year ago

Fireevil commented 1 year ago

Current Behaviour

If one crossfaction group tries to do icc gunship battle they find several problems.

part of the party cannot kill the mobs before ship, hacking faction forces you to kill all mobs making the "event" more dificult you cannot hack all mobs because some must have your faction during event. you need additional people caring about raid instead dedicate to attack the opposite ship. if you don't hack part of party cannot do nothing. maybe https://github.com/azerothcore/azerothcore-wotlk/src/server/scrIf one crossfaction group tries to do icc gunship battle they find several problems.

part of the party cannot kill the mobs before ship, hacking faction forces you to kill all mobs making the "event" more dificult you cannot hack all mobs because some must have your faction during event. you need additional people caring about raid instead dedicate to attack the opposite ship. if you don't hack part of party cannot do nothing. maybe https://github.com/azerothcoIf one crossfaction group tries to do icc gunship battle they find several problems.

part of the party cannot kill the mobs before ship, hacking faction forces you to kill all mobs making the "event" more dificult you cannot hack all mobs because some must have your faction during event. you need additional people caring about raid instead dedicate to attack the opposite ship. if you don't hack part of party cannot do nothing. maybe https://github.com/azerothcore/azerothcore-wotlk/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_faction_champions.cpp can be used to work properly on crossfaction group. re/azerothcore-wotlk/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_faction_champions.cpp can be used to work properly on crossfaction group. ipts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_faction_champions.cpp can be used to work properly on crossfaction group.

Expected Blizzlike Behaviour

.

Source

No response

Steps to reproduce the problem

.

Extra Notes

No response

AC rev. hash/commit

e2cfb5c

https://github.com/azerothcore/azerothcore-wotlk/commit/e2cfb5c5a95a38c278d76db8deecdb2596d543aa

Last rev

Operating system

Windows 10

Custom changes or Modules

No response

Tony931023 commented 1 year ago

This happens in many dungeons, which have events depending on the faction, perhaps something like mod-cfgb can be done, for pve, we would have to see if any developer is encouraged to modify the crossfaction, or put an issue with Bounty

Fireevil commented 1 year ago

But the event boss faction champion of Toc Work 100% cross raid and gunship battle no

Kitzunu commented 1 year ago

Most likely due to making it cross faction would mean polluting the script :D

YggdrasilWotLK commented 1 month ago

For those using ELUNA you could consider using this script or something similar to temporarily align the faction of all instance members to the faction of the first player to enter the instance: https://github.com/YggdrasilWotLK/ELUNA-Scripts/blob/main/Instance/SetFaction.lua

Hope this helps :)