search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.55k stars 2.63k forks source link

(Core/Movement): Fear is bad at walls/height checks. #16366

Open heyitsbench opened 1 year ago

heyitsbench commented 1 year ago

Current Behaviour

Currently, fearing a player sometimes sends players off cliffs, sometimes through walls. This can be observed in this video (taken from CC PTR a bit under half a year ago), or this video (taken from bc0ddaa3c2af2e7b0e92986741485d04c1a90a35, admittedly unrealistic situation to be in, but it's an excellent demonstration).

Expected Blizzlike Behaviour

Fear should not be sending players off cliffs (probably) and should never send players through walls.

Source

Assumption.

Steps to reproduce the problem

  1. .go zonexy 29.1 45.21 483 with two characters.
  2. Either be on a PvP realm with characters of opposite faction, or duel the other character.
  3. .learn 5782
  4. Cast it on the opposing character.
  5. Observe the feared character falls/goes through walls.

Extra Notes

Originally reported at https://github.com/chromiecraft/chromiecraft/issues/4643.

With the reproduction steps listed, I was able to produce the bug every time of five attempts. From what's been mentioned in the ChromieCraft Discord, it seems this bug happens very often during PvP environments (i.e. battlegrounds, likely to happen in arenas as well, though those aren't available on CC at this time to test).

AC rev. hash/commit

bc0ddaa3c2af2e7b0e92986741485d04c1a90a35

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

IntelligentQuantum commented 1 week ago

Confirm