azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

[QUEST]Magtheridon's Head Not on Display and No Buff (Horde & Alliance) #1685

Open gtao725 opened 5 years ago

gtao725 commented 5 years ago
SMALL DESCRIPTION:

When turning in the following quests:

[Alliance] The Fall of Magtheridon (https://wowgaming.altervista.org/aowow/?quest=11002) [Horde] The Fall of Magtheridon (https://wowgaming.altervista.org/aowow/?quest=11003)

There are 2 things that doesn not happen by the end of the hand in:

  1. Neither Alliance side nor Horde side gets the zone buff. (Trollbane's Command[https://wowgaming.altervista.org/aowow/?spell=39911] for Alliance or Nazgrel's Fervor[https://wowgaming.altervista.org/aowow/?spell=39913] for Horde)

  2. Magtheridon's Head is not displayed on a spike at the entrance of either Thrallmar (Horde) or Honor Hold (Alliance)

EXPECTED BLIZZLIKE BEHAVIOUR:

https://wow.gamepedia.com/Signs_of_victories (See section on Magtheridon) https://wow.gamepedia.com/Magtheridon%27s_Head

CURRENT BEHAVIOUR:
  1. Quest can be completed by both Alliance or Horde players but neither side gets buff and the head on a spike is not displayed for either faction.
STEPS TO REPRODUCE THE PROBLEM:
  1. .additem 32385 (for alliance) or .additem 32386 (for horde)
  2. .go creature id 16819 (for alliance) or .go creature id 3230 (for horde)
  3. hand in the quest and choose your reward. Trollbane(alliance) or Nazgrel(horde) will say something about your feat of strength.
  4. After that you will see you get no buff and outside near the entrance Magtheridon's Head on a spike is NOT SEEN anywhere... not for horde and not for alliance.
EXTRA NOTES:

Very similar mechanics to Nefarians Head on a spike in Orgrimmar and Stormwind.

BRANCH(ES):

master

AC HASH/COMMIT:

9eb6e9a

OPERATING SYSTEM:

Win 7/10/Svr 2016

MODULES:

N/A

OTHER CUSTOMIZATIONS:

N/A

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/72435728-quest-magtheridon-s-head-not-on-display-and-no-buff-horde-alliance?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F40032087&utm_medium=issues&utm_source=github).
ELdoBA commented 5 years ago

Will take a look on this

ghost commented 5 years ago

@poszer Is really dedicated to show off heads everywhere xD

ghost commented 3 years ago

Can confirm no head after quest completion nor buff.

Desktop 28-11-2020 16-48-39-879

sogladev commented 3 months ago

There are other multiple zone buffs that work incorrectly like this one

CMangos for reference

Joining/leaving Zone adds/removes player GUID to a list

void WorldState::HandlePlayerEnterZone(Player* player, uint32 zoneId)

https://github.com/cmangos/mangos-wotlk/blob/bd63be95ae8e084c748eb5129366a7533edc02c4/src/game/World/WorldState.cpp#L442

Added in: https://github.com/cmangos/mangos-wotlk/commit/0b87ca9d9edf2d4752a3c0f8e9cf85c6689ca861

Matheridon quest complete sets worldstate which loops through the vector and applies the spell https://github.com/cmangos/mangos-wotlk/blob/master/src/game/AI/ScriptDevAI/scripts/outland/hellfire_peninsula.cpp#L1586

ACore

no global zone remove/add exists? A playerscript can be used like the midsummer event

Should a single playerscript be used with a vectorGUID that stores/removes players like cmangos?

something like (WIP) https://github.com/sogladev/azerothcore-wotlk/blob/bec80d88d028d3bee8d139a3059895d62f7e6b86/src/server/scripts/Outland/zone_hellfire_peninsula.cpp#L623

Or is there a need for more global OnLeaveZone or OnEnterZone functions