azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.4k stars 2.55k forks source link

Clean up World Database #16942

Open Kitzunu opened 1 year ago

Kitzunu commented 1 year ago

Describe your feature request or suggestion in detail


walkline commented 1 year ago

I don't know much about the coupling of dbc and modules with the world DB. However, separating this data would make it impossible to use JOIN and other operations between the two databases. Would this not be an issue?

Kitzunu commented 1 year ago

The module one is more of a placeholder and will not be used by this repo at all, it is just for independent modules to use it instead of world, just to keep everything clean.

majority of _dbc files are just empty and act like an override to the .dbc files. and do not in any way operate with other tables

walkline commented 1 year ago

Understood about dbc, thanks.

Will module developers have the option to choose between the world DB (if their tables are coupled with world) and the modules DB (if they are independent)?

Kitzunu commented 1 year ago

Of course.

You could even just store everything in acore_auth if you desired 😅 Nobody can dictate what a module should do.

the main reasoning behind it was to clean up world db and to make it easier for module users to find the module-specific tables

michaeldelago commented 1 year ago

acore_module - a placeholder database module that can use instead of querying custom tables into acore_world

big fan

It'll probably be a good bit of time before most popular modules switch databases (but might be something we can wrangle through creating a PR with a script) but I think this is overall a good idea.

same with the dbc DB, it just kinda feels like noise when I'm scrolling through the databases