azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

[Paladin] Ardent Defender dual spec issue #16954

Open Annamaria-CC opened 1 year ago

Annamaria-CC commented 1 year ago

https://github.com/chromiecraft/chromiecraft/issues/5852

What client do you play on?

enUS

Faction

Alliance

Content Phase:

Generic

Current Behaviour

When swapping talents, ardent defender no longer procs, need to relog for it to work.

That does not seem to be the case

Expected Blizzlike Behaviour

Ardent defender should work when swapping back to prot talents

Source

image

Steps to reproduce the problem

get 2 specializations swap to spec with ardent defender find an enemy attack it die

Extra Notes

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/a779cca9e3a3d673761d6bbe6d1c5d1f51c2f6f3

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

GastonCK commented 1 year ago

So the steps are switch spec, switch back to prot and ardent defender won't work? coz I just did that and it did work. WoWScrnShot_080823_115808

Annamaria-CC commented 1 year ago

hmm weird. Ill need to check later

shaszun commented 1 year ago

It's not just that, whenever the ardent defender stops working as a tank you start getting tons more dmg. My guess is all passive talents stop working. And bug not trigger all the time, so far since heroic release I got it around 10 times. For me the only fix is to reset talents from the trainer, no dual spec swapping, reloging or whatever worked.

ghost commented 1 year ago

Testing together with Choof today yielded these results:

Respecing to prot with dual spec while inside heroic TBC dungeon (with or without RDF) or inside TBC Raids such as kara causes the Ardent Defender effect to become inactive. Specing to prot from a blank talent spec (no dual spec) while inside heroic TBC dungeon or TBC raids such as kara causes the Ardent Defender effect to become inactive. Doing any of this in a normal dungeon, classic dungeon (lvl 60) or outside dungeon will not result in bug.

There seems to be a problem with the game applying the aura belonging to AD when inside dungeons that have been tuned by CC. Please look at the custom nerf auras interfering with this spell.

Carriola-wotlk commented 3 weeks ago

Are you sure this bug hasn't already been fixed? I was trying to fix it myself, but I noticed that the Ardent Defender effects works correctly, even when changing specs. Here a video:

https://github.com/user-attachments/assets/35717590-7201-4e5d-b742-8094966e680b

I see that the PR with the fix was merged on September 15th, the same day as the last comment. But the build with the fix probably hadn't been made yet

@Rorschach91 have you tried?

fyi: @Nyeriah

Nyeriah commented 3 weeks ago

It’s extremely hard to reproduce. I doubt it was fixed.

Rorschach91 commented 3 weeks ago

@Carriola-wotlk I tried to reproduce it inside a dungeon, but ardent defender works well for me. I agree with @Nyeriah. If this bug is still present It's hard to reproduce.

Nyeriah commented 3 weeks ago

Did this happen during CC vanilla? How far back was the first occurrence?