azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.55k stars 2.62k forks source link

[TBC OHF] Ashbringer gem cleansing event unimplemented #17025

Closed elthehablo closed 1 year ago

elthehablo commented 1 year ago

Current Behaviour

Relevant NPCs (Tirion, Mograine etc.) stand around and say nothing

Expected Blizzlike Behaviour

They should have an event where they are shown cleansing the gem found near Blackrock Mountain into a gem that was used to craft Ashbringer. Event is supposed to trigger when a player enters the inn (areatrigger?). A pretty cool event imo.

Source

https://wowpedia.fandom.com/wiki/Ashbringer/Old_Hillsbrad_Ashbringer_event for texts

Steps to reproduce the problem

  1. go to Escape from Durnholde Keep (OHF)
  2. go to Southshore
  3. enter the inn
  4. observe there is no event

Extra Notes

Maybe TC has it implemented so we can cherry-pick? Otherwise need sniffs

AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/pull/17024/commits/27936da63dd888259157ff9c1e5e4d86c65eed2f

Operating system

Windows 11

Custom changes or Modules

None. not a clean DB but in this case that is not relevant.

fangshun2004 commented 1 year ago

I tested the gem purification event and it worked fine and there is a corresponding event in smartai WoWScrnShot_082023_062046 WoWScrnShot_082023_062142 WoWScrnShot_082023_062258 WoWScrnShot_082023_062312 WoWScrnShot_082023_062314 WoWScrnShot_082023_062326

elthehablo commented 1 year ago

Ye mb it was implemented. Oversight on my part