azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.5k stars 2.61k forks source link

Cannot swap bags unless old bag is empty #17084

Closed ghost closed 1 year ago

ghost commented 1 year ago

Originally reported https://github.com/chromiecraft/chromiecraft/issues/6070 Reported by: https://github.com/balleny

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

when you try to drag and drop an unused bag above a used bag, but the used bag contains items, you receive the error: "you can only do this with empty bags"

right now, you have to empty the bag, exchange it, and then you can refill it.

Expected Blizzlike Behaviour

You should be able to exchange a bag in use with a different bag from your inventory if

  1. the slots used/occupied in the bag are less or equal to the number of slots of the new bag
  2. you dont have conflicting itemtypes (regular bag with ores and herbs, trying to replace it with a herb-only bag)

Source

https://worldofwarcraft.fandom.com/et/wiki/Bag Confirmed as per stated in the wiki. In vanilla you needed to empty bags before changing them but this was fixed sometime during BC. Here is another thread discussing to add it to classic ahead of its time: https://www.reddit.com/r/classicwow/comments/9rqijf/swap_bags_without_emptyinghttps://worldofwarcraft.fandom.com/et/wiki/Bag

This is a consistent issue on cc.

Steps to reproduce the problem

.additem 38082 for gigantique bags equip a bag, put in 1 item. drag and drop a different bag ontop of the filled bag

Extra Notes

No response

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/4c287e2873c3464a64baafc8c93a47521bccfbc9

Operating system

Ubuntu 20.04

Modules

Customizations

None

Server

ChromieCraft

Kitzunu commented 1 year ago

iirc this is blizzlike. Can you provide a source from 335

elthehablo commented 1 year ago

We need the Benchman

Nyeriah commented 1 year ago

You can swap bags with items on retail yes done it all the time. Would make it virtually impossible to replace small bags early game otherwise without deleting a lot of items

Gultask commented 1 year ago

Don't know about retail retail but Classic I know for sure you can swap without removing items first

elthehablo commented 1 year ago

Might look into this. Seems tricky to solve. Especially since I know nothing about how bagspace is handled

ghost commented 1 year ago

Sorry I linked all the evidences into comment on cc GitHub. I'll copy them into the AC report too

Quote from wiki for those lazy to open link "If you want to equip a higher-capacity bag in place of a lower-capacity one (e.g, because it's full), you can swap out a larger nested bag for the smaller one and the items will automatically be transferred to the new bag. The smaller one then becomes empty and nested."

Kitzunu commented 1 year ago

That quote does not exist on wowwiki https://wowpedia.fandom.com/wiki/Bag. Or it was poorly translated from the link you provided

There is also nothing on it from 2010 https://wowpedia.fandom.com/wiki/Bag?oldid=2158120

I am not saying this issue is wrong, because I do not know, but I believe I remember reading somewhere long ago that this is a client limitation. Which would make this issue invalid. But don't quote me on that

heyitsbench commented 1 year ago

image

Kitzunu commented 1 year ago

https://github.com/azerothcore/azerothcore-wotlk/pull/17086

heyitsbench commented 1 year ago

Even more evidence that this was added by 3.3.5a: GameFAQs board article circa July '08.

ghost commented 1 year ago

You linked a different wiki. I quoted from the one I put in the report. And yeah there are a dozen forum discussions about it too.

heyitsbench commented 1 year ago

I quoted from the one I put in the report.

The wiki linked in the report includes no source, no patch for the changes, and no mention of it changing between vanilla/retail. The edit history is all well past-Wrath and almost certainly copied verbatim from another site. Excuse us if we don't regard it with much trust.

ghost commented 1 year ago

It's actually a rather trustworthy wotlk wiki that devotes special attention to outline cataclysm changes. It's definitely no less reliable than random comments based on individual player experiences. You're right it should not be the sole source used. How fortunate I provided another.

Kitzunu commented 1 year ago

How awesome we established this already and I already fixed the issue. So no need to comment about it anymore :) 👍

You linked a different wiki. I quoted from the one I put in the report.

Fair, I saw /et/ so I removed it from the link, as I obviously want an English website, and that automatically redirected me to wowpedia. I didn't see it was written in English because I went straight to see edit history, and that was definitely not in English. hence why I removed /et/ from the link

heyitsbench commented 1 year ago

So no need to comment about it anymore :) 👍

Proper sourcing is important.

ghost commented 1 year ago

How awesome we established this already and I already fixed the issue. So no need to comment about it anymore :) 👍

You linked a different wiki. I quoted from the one I put in the report.

Fair, I saw /et/ so I removed it from the link, as I obviously want an English website, and that automatically redirected me to wowpedia. I didn't see it was written in English because I went straight to see edit history, and that was definitely not in English. hence why I removed /et/ from the link

Don't worry it's just the game we play with Bench. He can't resist an opportunity to call my sources shit because I didn't sniff them with my own nose 😂

heyitsbench commented 1 year ago

Don't worry it's just the game we play with Bench. He can't resist an opportunity to call my sources shit because I didn't sniff them with my own nose 😂

Play nice.