azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.42k stars 2.57k forks source link

[PvP] Dispel magics (such as Purge, Tranquilizing shot and Dispel magic) remove all charges from a beneficial spell #17130

Closed Pyromanihack closed 1 year ago

Pyromanihack commented 1 year ago

Related issue: https://github.com/chromiecraft/chromiecraft/issues/4918

What client do you play on?

enUS

Faction

Both

Content Phase:

Generic

Current Behaviour

When you cast Purge, Tranquilizing Shot, or Dispel Magic on a player that has a beneficial spell with charges (like Nature's Grasp, Water Shield, Lightning Shield, all charges were dispelled.

If you try to cast the same offensive spells on a shaman that has Earth Shield, it removes only 2 charges (or 1 based on the rank's spell)

Expected Blizzlike Behaviour

I don't know what the correct behavior is, but I imagine that the current one is incorrect because it doesn't follow a precise rule

Source

I didn't find any source of the correct behavior, and right now I can't try to reproduce it on the PTR (but I guess it must be easy)

Steps to reproduce the problem

Make a druid Duel someone with an offensive dispel (priest, shaman, hunter) Cast natures grasp all 3 charges get purged

Extra Notes

No response

AC rev. hash/commit

6cd3b2a32cd9

Operating system

Ubuntu 20.04 - Windows 10

Modules

Customizations

None

Server

ChromieCraft

laasker commented 1 year ago

I belive its normal

Earth Shield have this spell attribute: image

While Nature's Grasp, Water Shield doesn't have it

Pyromanihack commented 1 year ago

Where do you take this source? It's an helpful tool to know 😁

laasker commented 1 year ago

it's the Spell-Editor tool https://github.com/stoneharry/WoW-Spell-Editor

You can also check on wotlk wowhead: (tho wotlk classic is a different client from the one we use" image

Pyromanihack commented 1 year ago

Ok so clearly this is not a bug, I'm closing this

avarishd commented 2 months ago

Additional source https://youtu.be/R25q7IPDEDg?t=962 Priest dispels all stacks (can see GCD on nameplates) & PW:S