search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.41k stars 2.57k forks source link

(Instance/Karazhan): Side entrance and servants' access doors have incorrect behavior. #17305

Open heyitsbench opened 1 year ago

heyitsbench commented 1 year ago

Current Behaviour

Both the side entrance door and the servant's access doors in Karazhan are unlocked.

Expected Blizzlike Behaviour

If I recall correctly, the side entrance door should be non-selectable/interactable. Once the player approaches it (from the inside of the tower), it should automatically open. It might automatically open from the other side as well once approached after probably Opera has been defeated, but I have not checked for that.

The servant's access door seems to be locked permanently (but selectable), but once you approach it (again, from the inside), it will automatically open.

Source

Wrath Classic partially, rumors and tall tales otherwise

Steps to reproduce the problem

  1. .tele kara
  2. Clear your way through the ballroom and its upper balcony.
  3. Open the servants' access door.
  4. Leave the instance.
  5. Go up to the side entrance.
  6. Enter the instance.
  7. Open the side entrance door.

Extra Notes

No response

AC rev. hash/commit

373fdd68bfc2317c2a90e2857a81f42713950e75

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

heyitsbench commented 1 year ago

This issue allows players to skip a substantial portion of the instance. Pretty uncool beans if you ask me.

heyitsbench commented 12 months ago

Both of these might use area triggers, I know the side entrance one almost definitely does. Here are the relevant triggers:

4191: Servant's Access Door
4522: Broken Stair (Side entrance)

As well, the Blood Drenched Door (used for Prince Tenris Mirkblood) may also make use of area triggers, specifically 5014 and 5015, as they are on each side of the door.

heyitsbench commented 11 months ago

They (not the Blood Drenched Door since can't test that) definitely use ATs to open/unlock.

avarishd commented 11 months ago

https://github.com/azerothcore/azerothcore-wotlk/pull/17493 fixed the side entrance.

heyitsbench commented 11 months ago

Side entrance opening in the first place isn't tied to an AT as of 62ef0db. Not fixed.

avarishd commented 11 months ago

It can't be just an area trigger to open the door, you can bypass the door (while locked) in various ways, it most likely contains a check, also same question for the servant door, it probably requires a boss check before that too.

And are the doors actually being unlocked when triggered by the AT or just visual (simply, opening opening for you when you get close)

heyitsbench commented 11 months ago

The doors are both locked until you pass into the area trigger. Once you pass into the trigger, it opens. Once it closes on its own timer, it becomes interactable as it is no longer locked. Wiping without unlocking the side entrance door via this manner (from Classic testing) will not allow the side entrance door to be opened when entering from outside. From what I've seen, the relevant ATs are not used whatsoever as of latest revision, which is most assuredly wrong.

[...] you can bypass the door (while locked) in various ways, it most likely contains a check, also same question for the servant door, it probably requires a boss check before that too.

If you've got any cases I can test on Classic to confirm any behaviors, feel free to point them out.

Nyeriah commented 11 months ago

The door visually opens and becomes unlocked after you walk into the area trigger on retail from the inside. Sure we can check the boss conditions to prevent abuse and such

.debug areatrigger helps checking areatriggers, it will show once you walk into it