azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.39k stars 2.55k forks source link

(DeathKnight): Gargoyle has incorrect auras. #18212

Open heyitsbench opened 7 months ago

heyitsbench commented 7 months ago

Current Behaviour

Currently, the death knight's Ebon Gargoyle when summoned has the following auras on it:

51996 - Death Knight Pet Scaling 02
54566 - Death Knight Pet Scaling 01
61017 - Hunter Pet Scaling 04 <---
61697 - Death Knight Pet Scaling 03
62137 - Avoidance
65221 - Command

Expected Blizzlike Behaviour

The Gargoyle should instead have the following auras:

36492 - Serverside - Summon Heal <---
51996 - Death Knight Pet Scaling 02
54566 - Death Knight Pet Scaling 01
61697 - Death Knight Pet Scaling 03
62137 - Avoidance
65221 - Command
67557 - Serverside - Pet Scaling - Master Spell 03 - Intellect, Spirit, Resilience <---
67561 - Serverside - Pet Scaling - Master Spell 06 - Spell Hit, Expertise, Spell Penetration <---

These spells may also need implementation.

Source

Wrath Classic (50664)

Steps to reproduce the problem

  1. .learn 49206
  2. Cast Summon Gargoyle.
  3. .list auras on the Ebon Gargoyle.

Extra Notes

No response

AC rev. hash/commit

d0eae390b61377c569af4bcf2ac647a23a21800b

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

heyitsbench commented 7 months ago

Possibly related (at least partially) to https://github.com/azerothcore/azerothcore-wotlk/issues/16420.

Joshmash commented 7 months ago

Will these fixes change the intervals between pet attacks? This problem was mentioned here https://github.com/azerothcore/azerothcore-wotlk/issues/16420#issuecomment-1902190937

heyitsbench commented 7 months ago

Will these fixes change the intervals between pet attacks?

Without a proper implementation, changing the auras the gargoyle uses means basically nothing. The scaling spells likely need their formulas corrected on top of the spells being properly applied.