search

azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.46k stars 2.59k forks source link

[Warrior/Mage] "DoT Munching" Deep Wounds/Ignite #18593

Closed Wheemix closed 2 months ago

Wheemix commented 6 months ago

https://github.com/chromiecraft/chromiecraft/issues/5669

Current Behaviour

image

Currently when you land 2 critical strikes at the same time frame, deep wounds is only registering 1 application.

Expected Blizzlike Behaviour

Each critical strike from the warrior should proc 1 application of deep wounds. image By description of the spell itself, each and every crit should apply 1 deep wound.

Source

Quote from official Blizzard Wotlk Classic patch notes (https://www.wowhead.com/wotlk/news/patch-notes-version-3-4-2-wotlk-classic-333579) confirming this as a bug and not intended 3.3.5 behaviour: "Fixed an issue that caused stacking damage over time effects to not properly stack when two effects that increase the magnitude of the DoT land simultaneously. Developers’ note: This resolves the so-called “DoT Munching” behavior seen predominately with spells like Ignite and Deep Wounds."

Steps to reproduce the problem

  1. Create warrior, and spec into deep wounds
  2. Get some gear and wep, and make a slam /startattack macro
  3. Get double crit from the auto+slam and check logs

Extra Notes

original Chromiecraft report by Cooties on May 26th, 2023: https://github.com/chromiecraft/chromiecraft/issues/5669

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/bc0ddaa3c2af2e7b0e92986741485d04c1a90a35

Operating system

Ubuntu 20.04

Custom changes or Modules

No response

heyitsbench commented 6 months ago

This issue is invalid per original Wrath. IMO, munching should be made into a config or made adjustable/removable by a module, but in terms of default behavior this issue is, again, invalid.