azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.36k stars 2.54k forks source link

Threat System Issues #18783

Open balleny opened 4 months ago

balleny commented 4 months ago

Current Behaviour

Threat system - or implementation of all raid bosses - has a major issue. abilities that should cause a npc to attack a different target, although lower on threat table (e.g. boss polymorphs https://github.com/chromiecraft/chromiecraft/issues/1 in threat and attacks #2 in threat), result in bosses leaving combat / resetting if all targets are affected by an ability that causes these change in attackable targets.

Expected Blizzlike Behaviour

if all targets are affected by an ability which causes the npc to de-prioritize, it should pick the target according to regular threat table and actually break this CC - or in case of an scripted RP, continue with that instead of resetting and leaving combat.

Source

retail & logic

Steps to reproduce the problem

this issue happens e.g. at Maiden in Kara or Aran in Kara. where repentance and polymorph respectively, can cause every target of the threat table to be temporarily crowd controlled. instead of breaking the highest target according to regular threat table then, the boss currently resets.

Extra Notes

this is a generic issue and not boss specific.

AC rev. hash/commit

https://github.com/chromiecraft/azerothcore-wotlk/commit/c863a8cfb59ed17692f9da2956b85a53ecc09ed7

Operating system

ubuntu

Custom changes or Modules

Chromiecraft

balleny commented 4 months ago

see also https://github.com/chromiecraft/chromiecraft/issues/6392 for a concrete example