azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.13k stars 2.46k forks source link

Hearthstone should not save orientation #18936

Closed Mat2095 closed 15 hours ago

Mat2095 commented 1 month ago

Current Behaviour

Setting the hearthstone-position includes the orientation.

Expected Blizzlike Behaviour

Setting the hearthstone-position should not include the orientation

Source

While the hearthstone DOES save the orientation in classic-WotLK and newer retail expansions, it did not do so during patch 3.3.5a. This feature was added in WoD (or maybe late MoP). Video from WotLK: https://www.youtube.com/watch?v=f4D2JkTeVrQ&t=7m40s https://www.youtube.com/watch?v=87RxQu2XUt8&t=60s Video from Cata: https://www.youtube.com/watch?v=ebieivVHMw8&t=540s Video from MoP: https://www.youtube.com/watch?v=d8-37KpJxT8&t=467s All these videos show hearthstone not saving the orientation. Then finally in WoD, it does save orientation: https://www.youtube.com/watch?v=xIEZBNS_E3o&t=375s

Steps to reproduce the problem

  1. Set hearthstone position
  2. Rotate
  3. Use hearthstone

Extra Notes

Saving the orientation was introduced in issue #13386 / PR #13389 . There was no actual source provided apart from "this is how it works on the wrath ptr" (which is true for WotLK-classic, but not for 3.3.5a) and "i distinctly remeber making sure to face the innkeeper back in the day"... Also note that TC does save orientation on their master-branch, but not on 3.3.5a (https://github.com/TrinityCore/TrinityCore/pull/27055).

AC rev. hash/commit

a8b69edeeed429c5da7927c8e342c5309a24cfbe

Operating system

Windows 11 x64

Custom changes or Modules

None

heyitsbench commented 1 month ago

Good find.