azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.62k stars 2.64k forks source link

Aggressor\Combat AI Aggro Reset and Engagement Problematic #19200

Open sudlud opened 5 months ago

sudlud commented 5 months ago

Current Behaviour

NPC Mobs that engage other npcs in combat seem to be resetting after a individual kill instead of staying and fight until the mob threat is cleared out. They appear to be resetting after each kill back to their home position and then they re-engage back out.

This issue came about from @malcrom durning scripting. I attempted to debug the issue, but the breaks i am setting seems to either be non consistent or just not breaking in spots that i hope would work, such as aggressor ai https://github.com/azerothcore/azerothcore-wotlk/blob/fad214efe018dcb56ce11e717e41e1eddea96599/src/server/game/AI/CoreAI/CombatAI.cpp#L29 https://github.com/azerothcore/azerothcore-wotlk/blob/fad214efe018dcb56ce11e717e41e1eddea96599/src/server/game/AI/CoreAI/CombatAI.cpp#L38 https://github.com/azerothcore/azerothcore-wotlk/blob/fad214efe018dcb56ce11e717e41e1eddea96599/src/server/game/AI/CreatureAI.cpp#L285

Video

Observing the footage of azerothcore master build (no modules or custom edits): You will see mobs will only target one creature at a time and not focus on aggro adjusting on to other threats, after the single target threat is killed, they return home before reaggroing again. The scourge focus on one Ranger. While the other rangers only focus one when engaged (same things pretty much). Problem seems to be the with the aggro system itself.

Expected Blizzlike Behaviour

Mob Groups when in conflict need to finish the fight before resetting back to their home location.

Source

Retail gameplay TBC Class Retail/TBC Classic PTR/Shadowlands Retail

Steps to reproduce the problem

Find a spot of two conflicting mobs, and observer their engagement.

Extra Notes

This is also a issue on Trinitycore as well. This may be difficult to be experience with single player gamers.

AC rev. hash/commit

https://github.com/azerothcore/azerothcore-wotlk/commit/fad214efe018dcb56ce11e717e41e1eddea96599

Operating system

Windows 10 x64 Pro

Custom changes or Modules

No response

sudlud commented 5 months ago

issue rebuilt from #9640