fix(Core/Spells): Midsummer spinning visual interrupt on gossip

sogladev commented 4 days ago

Changes Proposed:

This PR proposes changes to:

[x ] Core (units, players, creatures, game systems).
[ ] Scripts (bosses, spell scripts, creature scripts).
[ ] Database (SAI, creatures, etc).

the visual channeled spells are interrupted by gossip, however the aura associated with spinning and adding the xp buff is not

https://github.com/azerothcore/azerothcore-wotlk/blob/fd87ce1bf39b4b44c77734bcc7f6c1f22000d7b3/src/server/game/Handlers/NPCHandler.cpp#L293

https://github.com/azerothcore/azerothcore-wotlk/assets/46423958/5bd03eef-fc27-458e-bbb0-dbf170d1c7d5

changes: add AURA_INTERRUPT_FLAG_TALK to spin aura

Issues Addressed:

Closes

SOURCE:

The changes have been validated through:

[ ] Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
[ ] Sniffs (remember to share them with the open source community!)
[ ] Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
[ ] The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

[ ] Tested in-game by the author.
[ ] Tested in-game by other community members/someone else other than the author/has been live on production servers.
[ ] This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

[ ] This pull request can be tested by following the reproduction steps provided in the linked issue
[ ] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. 2. 3.

Known Issues and TODO List:

[ ]
[ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

sudlud commented 4 days ago

I would prefer a solution similiar to #17442 if possible

sudlud commented 4 days ago

E.g. adding

AURA_INTERRUPT_FLAG_TALK

Maybe?

sudlud commented 4 days ago

ah i only now saw that you already referenced that flag in the PR description. so yeah, those spells are probably just missing this flag?

sogladev commented 4 days ago

ah i only now saw that you already referenced that flag in the PR description. so yeah, those spells are probably just missing this flag?

I overlooked SpellInfoCorrections :smile: adding the flag worked

sudlud commented 4 days ago

Thanks for the update :) the title might also need an update as it's not related to scripts anymore

Nyeriah commented 4 days ago

Core/Spells

sogladev commented 4 days ago

updated title and description

azerothcore / azerothcore-wotlk