azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.13k stars 2.46k forks source link

fix(Script/GunshipBattle): Wipe if no player is on the deck #19239

Closed Kitzunu closed 2 days ago

Kitzunu commented 2 days ago

Changes Proposed:

This PR proposes changes to:

Issues Addressed:

SOURCE:

The changes have been validated through:

Tests Performed:

This PR has been:

How to Test the Changes:

1. 2. 3.

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

Nyeriah commented 2 days ago

image

Get rid of this, its not being used