azerothcore / azerothcore-wotlk

Complete Open Source and Modular solution for MMO
http://www.azerothcore.org
GNU Affero General Public License v3.0
6.4k stars 2.56k forks source link

(DB/Quest) Deeprun Rat Roundup #19572

Closed Blackbird102 closed 2 weeks ago

Blackbird102 commented 1 month ago

Current Behaviour

Expected Blizzlike Behaviour

Source

https://www.youtube.com/watch?v=4Phvjninx_s

Steps to reproduce the problem

Be level 10 or higher a do the quest as described above

Extra Notes

No response

AC rev. hash/commit

AzerothCore rev. f5e44cd8a65a+ 2024-08-01 15:41:23 +0800 (Playerbot branch) (Win64, RelWithDebInfo, Static) Connected players: 1. Characters in world: 0. Connection peak: 1. Server uptime: 6 minute(s) 17 second(s) Update time diff: 1ms. Last 500 diffs summary: |- Mean: 1ms |- Median: 1ms |- Percentiles (95, 99, max): 3ms, 4ms, 4ms Using SSL version: OpenSSL 3.3.1 4 Jun 2024 (library: OpenSSL 3.3.1 4 Jun 2024) Using Boost version: 1.85.0 Using CMake version: 3.30.1 Using MySQL version: 80039 Found MySQL Executable: D:/Programme/MySQL/MySQL Server 8.0/bin/mysql.exe Compiled on: Windows 10.0.22631 Worldserver listening connections on port %hu Realmlist (Realm Id: 1) configured in port 8085 VMAPs status: Enabled. LineOfSight: true, getHeight: true, indoorCheck: true MMAPs status: Enabled maps directory located in D:/WoW/AzerothCorePlayerBotsBuild/bin/RelWithDebInfo/Data/maps. Total size: 291014951 bytes vmaps directory located in D:/WoW/AzerothCorePlayerBotsBuild/bin/RelWithDebInfo/Data/vmaps. Total size: 658130721 bytes mmaps directory located in D:/WoW/AzerothCorePlayerBotsBuild/bin/RelWithDebInfo/Data/mmaps. Total size: 2192910844 bytes Default DBC locale: enUS. All available DBC locales: enUS Using World DB: ACDB 335.12-dev Using Playerbots DB Revision: Latest LoginDatabase update: 2024_01_20_00.sql Latest CharacterDatabase update: playerbots_names.sql Latest WorldDatabase update: zz_optional_aq_quest_nerf.sql LoginDatabase queue size: 0 CharacterDatabase queue size: 0 WorldDatabase queue size: 0 PlayerbotsDatabase queue size: 0 List of enabled modules: |- mod-individual-progression |- mod-playerbots

Operating system

Windows 11 x64

Custom changes or Modules

No response

Blackbird102 commented 1 month ago

Hey there, I came across the quest that is not blizzlike. I just set up an Azeroth Core server a few days ago and read up on the project and created a fix. Specifically, I adjusted the smart scripts so that the rats no longer have to be killed, but can be caught via the flute and this is counted as quest progress.

I made a Pull Request. This is my first fix. Feel free to comment if I have done something wrong or could do something better.

How do I link my pull request to this Issue? (https://github.com/azerothcore/azerothcore-wotlk/pull/19573)

Ceikry commented 1 month ago

Can't seem to reproduce, killing the rats does nothing and they only respond to the flute.